chore: Write read me for the Markdoc config. #7989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: integration
ElianCodes
reviewed
Aug 18, 2023
There was a problem hiding this comment.
hey @louiss0, thanks for your PR! I left a couple of changes for you to review!
fix: Make sentences more explicit Co-authored-by: Elian ☕️ <hello@elian.codes>
fix: Make config sentence clearer Co-authored-by: Elian ☕️ <hello@elian.codes>
fix: Change placing for sentences for markdown Co-authored-by: Elian ☕️ <hello@elian.codes>
fix: Use one sentence instead of a list Co-authored-by: Elian ☕️ <hello@elian.codes>
fix: Remove all words that are "the" from sentences that talk about schema config Co-authored-by: Elian ☕️ <hello@elian.codes>
I decided to commit all of your suggestions. Nice ones. |
|
@bholmesdev, can you take one final look on this one, to make sure it matches? |
bholmesdev
reviewed
Aug 25, 2023
Co-authored-by: Ben Holmes <hey@bholmes.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
I looked at a preview inside of Markdown to see if things were good.
Docs
The change is the change to a read-me file I was not told to change the docs at all.
Context
I was requested by Ben to change the read-me of the markdoc folder here
With this change people will be able to use Markdoc in VSCode with it's Language Server.