Improve Package Detection #8306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r, standardized variable names, and fixed integration addition command Replaced preferred-pm and which-pm with @skarab/detect-package-manager. Standardized variable names from `pkgManager` to `packageManager`. Fixed the `bunx astro add` command for adding integrations.
github-actions
bot
added
pkg: create-astro
jacobdalamb
changed the title
🦋 Changeset detectedLatest commit: b075b65 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bluwy
reviewed
Sep 5, 2023
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
bluwy
approved these changes
Sep 5, 2023
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
pkgManagertopackageManager.bunx astro addcommand correctly uses bun.Previous attempts
#8219
#8150
Testing
Manually tested. Here's a screenshot
Docs
https://docs.astro.build/en/recipes/bun/