Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support in detecting Bun #8150

Closed
wants to merge 7 commits into from
Closed

Better support in detecting Bun #8150

wants to merge 7 commits into from

Conversation

jacobdalamb
Copy link
Contributor

@jacobdalamb jacobdalamb commented Aug 18, 2023 •
edited
Loading

Changes

Testing

Tested manually. Here's a screenshot.
works

Docs

Sister documentation PR: withastro/docs#4052
https://docs.astro.build/en/recipes/bun/

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: df341a2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 18, 2023
@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Aug 20, 2023
@ematipico
Copy link
Member

@jacobthesheep Thank you for the contribution. Have you tested the changes? It seems you haven't. Care to share some screenshots?

@jacobdalamb jacobdalamb changed the title Detect Bun in astro add Detect Bun as a package manager Aug 23, 2023
@jacobdalamb jacobdalamb changed the title Detect Bun as a package manager Better support in detecting Bun as a package manager Aug 23, 2023
@jacobdalamb jacobdalamb changed the title Better support in detecting Bun as a package manager Better support in detecting Bun Aug 23, 2023
@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) labels Aug 24, 2023
@jacobdalamb jacobdalamb mentioned this pull request Aug 30, 2023
Merged
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinhacks colinhacks colinhacks left review comments

@natemoo-re natemoo-re natemoo-re left review comments

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jacobdalamb @ematipico @colinhacks @natemoo-re