Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deno): do not set vite.ssr.noExternal #8652

Merged
merged 2 commits into from
Sep 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/spotty-dryers-exist.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@astrojs/deno': patch
---

Fixed an issue where deno integration broke some frameworks.
4 changes: 1 addition & 3 deletions packages/integrations/deno/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ export default function createIntegration(args?: Options): AstroIntegration {
`[@astrojs/deno] Otherwise, this adapter is not required to deploy a static site to Deno.`
);
}

},
'astro:build:setup': ({ vite, target }) => {
if (target === 'server') {
Expand All @@ -149,9 +150,6 @@ export default function createIntegration(args?: Options): AstroIntegration {
(vite.resolve.alias as Record<string, string>)[alias.find] = alias.replacement;
}
}
vite.ssr = {
noExternal: COMPATIBLE_NODE_MODULES,
};
Comment on lines -152 to -154
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noExternal was set to true originally. I had to change it to the list of bare node built-in modules in #7288. But apparently, it doesn't need to be set at all.


if (Array.isArray(vite.build.rollupOptions.external)) {
vite.build.rollupOptions.external.push(DENO_IMPORTS_SHIM);
Expand Down
Loading