Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vercel): fallback to static 404.html #9648

Merged
merged 4 commits into from
Jan 10, 2024
Merged

fix(vercel): fallback to static 404.html #9648

merged 4 commits into from
Jan 10, 2024

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Jan 8, 2024 •
edited
Loading

Changes

  • Closes Infinite 404 loop in prod on Vercel #9028 The issue exposes a weak point in routing - a code path where astro has to make a fetch call to itself. While this one specific side-effect is addressed, the error-prone approach remains in the codebase.
  • Closes output: "hybrid" fails to show 404 page. #9615
  • If 404.astro exists and is prerendered, it is used as the catch all route.
  • All on-demand rendered routes now have an entry that points the serverless function. Previously, a single catch-all route pointed to the serverless function.

Testing

image

Docs

Does not affect usage.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c87e8d9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jan 8, 2024
@lilnasy lilnasy marked this pull request as ready for review January 8, 2024 23:20
natemoo-re
natemoo-re approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks for fixing this!

MoustaphaDev

This comment was marked as duplicate.

Sign in to view

MoustaphaDev
MoustaphaDev approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@MoustaphaDev MoustaphaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lilnasy lilnasy merged commit d7f1903 into withastro:main Jan 10, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 10, 2024
Merged
@lilnasy lilnasy deleted the fix/9028 branch January 12, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

@MoustaphaDev MoustaphaDev MoustaphaDev approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

output: "hybrid" fails to show 404 page. Infinite 404 loop in prod on Vercel
3 participants
@lilnasy @natemoo-re @MoustaphaDev