Add tests for TSX sourcemaps #462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
natemoo-re
force-pushed
the
tsx-sourcemaps-tests
branch
from
82ff521
to
91bcdc9
Compare
Merged
|
Closing this in favor of #518 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This adds some tests for the source maps generated when doing the TSX output. This also add a test for #461, though the "solution" in the test is an idealist one, I think
The expected offsets should be correct, however building failing tests is not super convenient 馃槄 A more extensive test suite for this is to run the tests from the language server's compiler output PR, if the sourcemaps are correct, all tests should pass
Testing
It's tests all the way down
Docs
N/A