TSX Sourcemaps

[natemoo-re]

Changes

• Gets convertToTSX sourcemaps working
• Adds test coverage for TSX sourcemaps
• Lays the foundation for better JS sourcemaps/test coverage
• Supercedes Add tests for TSX sourcemaps #462

Testing

Lots of tests added

Docs

N/A

[changeset-bot]

🦋 Changeset detected

Latest commit: ae14f48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@astrojs/compiler	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[Princesseuh]

Living feedback document here:

Source map issues

• Everything seems to be off by one
• The source parameter is always ['<object>'] instead of the actual file information, this makes generatedPositionFor calls fails when they're done using the proper file info (possibly same problem as the second output issue?)

Output issues

• Invalid markup should be left as is, to support completions on incomplete tags
• Filenames don't seems to be processed correctly, no matter what I pass, I get the same result: object__AstroComponent_

Misc

• It'd be great if the types were exported (TSXResult). Also it seems like the type is wrong, map is an object not a string

[FredKSchott]

I'll leave this for @Princesseuh and you to review, just saying how exciting it is to see this PR!

[matthewp]

lgtm, nothing blocking but a couple of comments. nice tests!

[jasikpark]

should packages/compiler/deno/astro.wasm be .gitignore'd?

[natemoo-re]

Yeah good call @jasikpark, we needed it for deploying the astro_compiler Deno package, but it's not maintained so we can probably drop it. Will do that in another PR.

[jasikpark]

oh, I just meant that build artifacts should be git-ignored :p

do you mean that the wasm had to be commited to the git repo?

[natemoo-re]

do you mean that the wasm had to be commited to the git repo?

Yep, to be included in the Deno package, that particular build artifact had to be committed. My guess is that the publishing workflow is more flexible than last time I tried, but we're not maintaining it, so no need to try to get it working.

[Princesseuh]

Passes the language-server's test suite! 🥳

Remaining fixes (if there's any) can definitely be tackled in separate PRs. Awesome work Nate!

[matthewp]

Wow, what a big effort, congrats @natemoo-re @Princesseuh