-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for non-html route encoding option #1434
Add docs for non-html route encoding option #1434
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Link to new doc content in preview: https://deploy-preview-1434--astro-docs-2.netlify.app/en/core-concepts/astro-pages/#non-html-pages |
Hi @altano, thanks for submitting some documentation to go along with your feature PR withastro/astro#4549 ! I've converted this PR to a draft so that it does not get merged before the corresponding feature does, as we do with all docs that are awaiting approval elsewhere first. When that PR is merged, this can be un-marked as draft and reviewed at that time. Just so you know what's happening here! 😄 |
Hi @altano! I can see that the upstream PR in the Astro repo looks like it will be merged for an upcoming release, so we can start editing it here! 🥳 I'm leaving it as a draft so that it does not get merged before the release, and you might notice the merge in the other repository before I do, so feel free to come back and comment here to let us know when it's safe to un-draft this one. 😄 |
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
What kind of changes does this PR include?
This is to document a PR I'm publishing to astro core that adds the
encoding
option to non-html routes in SSG mode.Description
This PR adds documentation to complement withastro/astro#4549. The doc change looks like this: