Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for non-html route encoding option #1434

Merged

Conversation

altano
Copy link
Contributor

@altano altano commented Aug 30, 2022

What kind of changes does this PR include?

This is to document a PR I'm publishing to astro core that adds the encoding option to non-html routes in SSG mode.

Description

This PR adds documentation to complement withastro/astro#4549. The doc change looks like this:

image

@netlify
Copy link

netlify bot commented Aug 30, 2022

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1c162ff
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/631bb9f3716b6d0008b0c381
😎 Deploy Preview https://deploy-preview-1434--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@altano
Copy link
Contributor Author

altano commented Aug 30, 2022

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Aug 30, 2022
@sarah11918 sarah11918 marked this pull request as draft August 30, 2022 10:13
@sarah11918
Copy link
Member

Hi @altano, thanks for submitting some documentation to go along with your feature PR withastro/astro#4549 !

I've converted this PR to a draft so that it does not get merged before the corresponding feature does, as we do with all docs that are awaiting approval elsewhere first. When that PR is merged, this can be un-marked as draft and reviewed at that time. Just so you know what's happening here! 😄

@sarah11918
Copy link
Member

Hi @altano! I can see that the upstream PR in the Astro repo looks like it will be merged for an upcoming release, so we can start editing it here! 🥳

I'm leaving it as a draft so that it does not get merged before the release, and you might notice the merge in the other repository before I do, so feel free to come back and comment here to let us know when it's safe to un-draft this one. 😄

altano and others added 2 commits September 6, 2022 19:25
@sarah11918 sarah11918 marked this pull request as ready for review September 9, 2022 15:56
@kevinzunigacuellar kevinzunigacuellar merged commit 35a8e4a into withastro:main Sep 9, 2022
@altano altano deleted the alan/non-html-route-encoding branch September 10, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants