Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(es): revise and elaborate typescript intro #1707

Merged
merged 4 commits into from
Oct 4, 2022
Merged

i18n(es): revise and elaborate typescript intro #1707

merged 4 commits into from
Oct 4, 2022

Conversation

fredoist
Copy link
Contributor

@fredoist fredoist commented Oct 3, 2022

What kind of changes does this PR include?

  • New or updated content
  • Translated content

Description

@netlify
Copy link

netlify bot commented Oct 3, 2022

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 185e7da
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/633ba9b273b4690007f0e63d
😎 Deploy Preview https://deploy-preview-1707--astro-docs-2.netlify.app/es/guides/typescript
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 3, 2022
Copy link
Contributor

@AbrahamX3 AbrahamX3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola, deje algunas sugerencias en la review, me gustaría ver que opinas 🙌

src/pages/es/guides/typescript.md Outdated Show resolved Hide resolved
src/pages/es/guides/typescript.md Outdated Show resolved Hide resolved
src/pages/es/guides/typescript.md Outdated Show resolved Hide resolved
Co-authored-by: Abraham <78459953+AbrahamX3@users.noreply.github.com>
Copy link
Contributor

@marsidev marsidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍🏼

@kevinzunigacuellar kevinzunigacuellar merged commit 091bbf8 into withastro:main Oct 4, 2022
@kevinzunigacuellar kevinzunigacuellar added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 4, 2022
@fredoist fredoist deleted the typescript branch October 26, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants