Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(es): check grammar for core-concepts, reference, and integrations pages #1739

Merged
merged 7 commits into from
Oct 9, 2022
Merged

i18n(es): check grammar for core-concepts, reference, and integrations pages #1739

merged 7 commits into from
Oct 9, 2022

Conversation

fredoist
Copy link
Contributor

@fredoist fredoist commented Oct 7, 2022 •
edited
Loading

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)

Description

  • What does this PR change?
    • Check and fix minor grammar typos for core-concepts pages
    • Check and fix minor grammar typos for reference pages
    • Check and fix minor grammar typos for integrations page
    • Check and fix minor grammar typos for astro guides pages

@netlify
Copy link

netlify bot commented Oct 7, 2022 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 18872a6
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63423905bed6ae00087ba0bc
😎 Deploy Preview https://deploy-preview-1739--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 7, 2022
kevinzunigacuellar
kevinzunigacuellar reviewed Oct 7, 2022
View reviewed changes
Copy link
Sponsor Member

@kevinzunigacuellar kevinzunigacuellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gracias por la PR @fredoist!! 🚀 deje algunos comentarios

src/pages/es/core-concepts/framework-components.md Outdated Show resolved Hide resolved
src/pages/es/integrations/integrations.md Show resolved Hide resolved
@fredoist @kevinzunigacuellar
i18n(es): update framework-components.md
197f5e1 
Co-authored-by: Kevin Zuniga Cuellar <46791833+kevinzunigacuellar@users.noreply.github.com>
dreyfus92
dreyfus92 reviewed Oct 7, 2022
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algunas sugerencias @fredoist, buen trabajo. 😄

src/pages/es/core-concepts/astro-components.md Outdated Show resolved Hide resolved
src/pages/es/core-concepts/sharing-state.md Show resolved Hide resolved
src/pages/es/core-concepts/sharing-state.md Show resolved Hide resolved
src/pages/es/core-concepts/sharing-state.md Show resolved Hide resolved
src/pages/es/core-concepts/sharing-state.md Show resolved Hide resolved
src/pages/es/core-concepts/sharing-state.md Show resolved Hide resolved
src/pages/es/core-concepts/sharing-state.md Show resolved Hide resolved
src/pages/es/core-concepts/sharing-state.md Show resolved Hide resolved
src/pages/es/guides/server-side-rendering.md Show resolved Hide resolved
src/pages/es/reference/directives-reference.md Outdated Show resolved Hide resolved
kevinzunigacuellar
kevinzunigacuellar approved these changes Oct 9, 2022
View reviewed changes
Copy link
Sponsor Member

@kevinzunigacuellar kevinzunigacuellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kevinzunigacuellar kevinzunigacuellar added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 9, 2022
@kevinzunigacuellar kevinzunigacuellar merged commit 02b2fc1 into withastro:main Oct 9, 2022
@fredoist fredoist deleted the grammar-check branch October 26, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreyfus92 dreyfus92 dreyfus92 left review comments

@kevinzunigacuellar kevinzunigacuellar kevinzunigacuellar approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fredoist @kevinzunigacuellar @dreyfus92