Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for opening the repo in gitpod #1751

Merged
merged 3 commits into from
Oct 19, 2022
Merged

support for opening the repo in gitpod #1751

merged 3 commits into from
Oct 19, 2022

Conversation

naveennamani
Copy link
Contributor

What kind of changes does this PR include?

  • Something else!

Description

Participating in HACKTOBERFEST

@netlify
Copy link

netlify bot commented Oct 8, 2022 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 53f526e
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/634fd3222fe59c0009fd9509
😎 Deploy Preview https://deploy-preview-1751--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918
Copy link
Member

Ha! I have done this myself on the branch I'm currently using regularly! ;)

We're going to have to check with the team on this though, since many do use Gitpod at least some of the time, whether this is the action they want. We've purposely ignored that file so that people don't commit back their own custom gitpod.yml setups.

@sarah11918 sarah11918 added should this be documented? Need to figure out whether this is something to add to documentation or not site improvement Some thing that improves the website functionality - ask @delucis for help! hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest labels Oct 10, 2022
delucis
delucis approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a helpful addition. Thank you @naveennamani!

@sarah11918
Copy link
Member

Hi @naveennamani! We finally had a chance to discuss this, and I think your Gitpod defaults look good, so let's get this merged! 🥳 (I also just opened a branch on the repo without a gitpod.yml for the first time in a while, and was reminded how helpful this was going to be!) Thanks so much for this contribution, and welcome to Team Docs! 🚀

@sarah11918 sarah11918 removed the should this be documented? Need to figure out whether this is something to add to documentation or not label Oct 19, 2022
@sarah11918 sarah11918 merged commit 36843a1 into withastro:main Oct 19, 2022
@naveennamani
Copy link
Contributor Author

Thank you @sarah11918 for your prompt response and support. Looking for opportunities for more contributions.

Have a good day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest site improvement Some thing that improves the website functionality - ask @delucis for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supporting "Open in gitpod" for quick document changes
3 participants
@naveennamani @sarah11918 @delucis