Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated Vercel 404 workaround #2121

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Remove outdated Vercel 404 workaround #2121

merged 2 commits into from
Dec 9, 2022

Conversation

delucis
Copy link
Member

@delucis delucis commented Nov 29, 2022

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)

Description

@netlify
Copy link

netlify bot commented Nov 29, 2022 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit a7fbb47
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63935f9fd081210008f16ae1
😎 Deploy Preview https://deploy-preview-2121--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918
Copy link
Member

LGTM, @delucis!

@sarah11918 sarah11918 added the improve documentation Enhance existing documentation (e.g. add an example, improve description) label Nov 30, 2022
@delucis delucis added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Nov 30, 2022
@delucis delucis self-assigned this Dec 1, 2022
@delucis
Copy link
Member Author

delucis commented Dec 3, 2022 •
edited
Loading

Small update: just tried deploying the basics template to Vercel, added a 404.astro, and still seeing the previous behaviour not picking up the custom 404. Going to assume the fix isn’t deployed yet — will test again next week.

@delucis
Copy link
Member Author

delucis commented Dec 9, 2022

Re-ran my test deployment and this now seems to be fixed! 🥳

@delucis delucis merged commit e6f4c3c into main Dec 9, 2022
@delucis delucis deleted the chris/vercel branch December 9, 2022 16:26
@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@delucis delucis

Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucis @sarah11918