Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak i18n guide #439

Merged
merged 3 commits into from
May 4, 2022
Merged

Tweak i18n guide #439

merged 3 commits into from
May 4, 2022

Conversation

delucis
Copy link
Member

@delucis delucis commented May 4, 2022

  • Link to the i18n guide from the main repo README
  • Reorder the i18n guide sections slightly to get the key engagement section up top
  • Add a link to our snazzy new overview issue 🥳

@delucis delucis requested a review from sarah11918 May 4, 2022 21:44
@netlify
Copy link

netlify bot commented May 4, 2022 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0b0b57e
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6272f3a3340bb700098ba10a
😎 Deploy Preview https://deploy-preview-439--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@delucis delucis mentioned this pull request May 4, 2022
Closed
24 tasks
sarah11918
sarah11918 approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@delucis delucis merged commit cf91756 into withastro:main May 4, 2022
@delucis delucis deleted the delucis/docs-guide-tweak branch May 4, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delucis @sarah11918