Fix fallback favicon contrast issues #5818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delucis
added
the
site improvement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looking good!
|
|
Should i be able to see this in the preview? I still see this @delucis |
Favicons are usually cached pretty aggressively, so perhaps not. Is that Chrome? You might be able to force it with a “force reload” (Ctrl + Shift + R I think? If not, from the View menu when pressing Shift.) |
|
Couldn't seem to force a reload on my end, but I'll trust you and will report back if it doesn't eventually work! |
sarah11918
approved these changes
Dec 18, 2023
delucis
added
the
Merge Queue
ematipico
pushed a commit
that referenced
this pull request
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Updates our fallback favicon (a
.icofile used by browsers that don’t support SVG favicons — primarily Safari) to a variant with a background colour.The current fallback favicon uses a transparent background, making the white “A” in the Astro logo more or less invisible in light mode browsers (see #5792). In the main SVG favicon the “A” switches colour automatically based on user colour scheme, but we can’t use the same approach for the static fallback.
I opted for a solid background colour as the cleanest solution here. I also experimented with a dark outline around the logo, but at the small scale used for favicons, this looks pretty ugly.
Here’s a quick before/after side-by-side, which also helpfully demonstrates the contrast issue:
Related issues & labels (optional)