Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low Contrast Favicon in Safari #5792

Closed
mingjunlu opened this issue Dec 15, 2023 · 2 comments 路 Fixed by #5818
Closed

Low Contrast Favicon in Safari #5792

mingjunlu opened this issue Dec 15, 2023 · 2 comments 路 Fixed by #5818

Comments

@mingjunlu
Copy link
Contributor

馃搵 Explain your issue

Hi there 馃憢

I noticed that the contrast of the favicon is kind of low in Safari. I think that the team might want to know 馃檪

鎴湒 2023-12-15 涓婂崍10 42 37

@delucis
Copy link
Member

delucis commented Dec 17, 2023

Thanks for reporting @mingjunlu! Which version of Safari is this? The docs use an SVG favicon that uses a @media query to adapt to the user鈥檚 current colour scheme, but Safari doesn鈥檛 support SVG favicons, so we fall back to a static .ico icon in these cases.

We could probably work around this with a dark border around the fallback icon, so users of Safari in light mode get a better experience.

@mingjunlu
Copy link
Contributor Author

mingjunlu commented Dec 17, 2023

Hi @delucis, sorry for not mentioning the version. I'm using Safari 17.2 (light mode).

Adding a border sounds like a good idea! 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants