Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrite toolbar reference page for new APIs #7821

Merged
merged 15 commits into from
Apr 24, 2024

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Apr 9, 2024

Description (required)

Rewrite the toolbar api reference to match new APIs

Related issues & labels (optional)

withastro/astro#10665 & withastro/astro#10667 rework how to make dev toolbar APIs to make it easier to make apps

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 24, 2024 0:26am
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Apr 24, 2024 0:26am

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Apr 9, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 15, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/dev-toolbar-app-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few initial comments reading through the file diff here (because some of what's showing up as "new" isn't really new).

I will also do a review comparing both live docs and the deploy preview here, but just a few tiny things that stood out to me here!

@sarah11918
Copy link
Member

OK! Looking great @Princesseuh ! See my commit above with some light touches (some of them outside of GitHub's editing area, so easier just to make directly going through the page) and confirm everything I did is correct...and desirable! Also a couple of questions/notes/confirmation left unresolved here! But, very close to good to go, I think!

@sarah11918
Copy link
Member

sarah11918 commented Apr 22, 2024

OK! I made a commit to address those comments, and otherwise this is ready for your approval!

I'll be making a 4.7.0 branch and pointing these two PRs to them so that they are aware of each other. That will fix the failing link in the other one, and allow me to integrate the link on this page I added in the other PR.

@sarah11918
Copy link
Member

Merging into 4.7.0 branch for final checks!

@sarah11918 sarah11918 merged commit 7cb507a into 4.7.0 Apr 24, 2024
2 of 3 checks passed
@sarah11918 sarah11918 deleted the feat/toolbar-improvements branch April 24, 2024 12:19
@sarah11918 sarah11918 mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants