-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rewrite toolbar reference page for new APIs #7821
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few initial comments reading through the file diff here (because some of what's showing up as "new" isn't really new).
I will also do a review comparing both live docs and the deploy preview here, but just a few tiny things that stood out to me here!
OK! Looking great @Princesseuh ! See my commit above with some light touches (some of them outside of GitHub's editing area, so easier just to make directly going through the page) and confirm everything I did is correct...and desirable! Also a couple of questions/notes/confirmation left unresolved here! But, very close to good to go, I think! |
OK! I made a commit to address those comments, and otherwise this is ready for your approval! I'll be making a 4.7.0 branch and pointing these two PRs to them so that they are aware of each other. That will fix the failing link in the other one, and allow me to integrate the link on this page I added in the other PR. |
Merging into 4.7.0 branch for final checks! |
Description (required)
Rewrite the toolbar api reference to match new APIs
Related issues & labels (optional)
withastro/astro#10665 & withastro/astro#10667 rework how to make dev toolbar APIs to make it easier to make apps