Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.7.0 minor release #8002

Merged
merged 7 commits into from
Apr 25, 2024
Merged

4.7.0 minor release #8002

merged 7 commits into from
Apr 25, 2024

Conversation

sarah11918
Copy link
Member

@sarah11918 sarah11918 commented Apr 24, 2024 •
edited
Loading

Description (required)

4.7 Minor release docs:

#7983 - update CLI reference page for astro preferences
#7821 - update Dev Toolbar App API reference with new helpers
#7922 - adds new dev toolbar app recipe (also updates Dev Toolbar API and Guide pages with link to recipe)

@Princesseuh @sarah11918
Recipe for building a toolbar app (#7922)
963980c 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@sarah11918 sarah11918 added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Apr 24, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 25, 2024 10:34am
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Apr 25, 2024 10:34am

@sarah11918 sarah11918 added this to the 4.7.0 milestone Apr 24, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 24, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/dev-toolbar.mdx Source changed, localizations will be marked as outdated.
en recipes/making-toolbar-apps.mdx Source added, will be tracked.
en reference/cli-reference.mdx Source changed, localizations will be marked as outdated.
en reference/dev-toolbar-app-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@Princesseuh @sarah11918
feat: add small mention of available preferences (#7983)
925be4f 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
rgilsimoes
rgilsimoes reviewed Apr 25, 2024
View reviewed changes
src/content/docs/en/recipes/making-toolbar-apps.mdx Outdated

UI frameworks like React, Vue, or Svelte can also be used to create dev toolbar apps. These frameworks provide a more declarative way to create UIs and can make your code more maintainable and easier to read.

The same motivational dev toolbar app built into your existing Astro project earlier on this page with JavaScript can be built instead using a UI framework (e.g. Preact). Depending on your chosen framework, you may or may not require a build step.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: «...built using a framework (e.g. Preact) instead.»

rgilsimoes
rgilsimoes reviewed Apr 25, 2024
View reviewed changes
src/content/docs/en/recipes/making-toolbar-apps.mdx Outdated
The same motivational dev toolbar app built into your existing Astro project earlier on this page with JavaScript can be built instead using a UI framework (e.g. Preact). Depending on your chosen framework, you may or may not require a build step.

:::note
However your choose to build your dev toolbar app, using JavaScript or a UI framework, you will still need to [create the integration](#creating-the-astro-integration) that adds your app to the dev toolbar.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

«However your choice... »?
«However you choose... »?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

rgilsimoes
rgilsimoes reviewed Apr 25, 2024
View reviewed changes
src/content/docs/en/reference/dev-toolbar-app-reference.mdx Outdated

This is the core part of the app. This function will be called when the app is loaded, which will either be when the browser is idle or when the user clicks on the app in the UI.
This function takes an object with an [`init()`](#init) function that will be called when the dev toolbar app is loaded. It can also take a [`beforeTogglingOff()`](#beforetogglingoff) function that will run when the toolbar app is clicked to toggle off the its active status.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

«...toggle off the it's active status...» or
«...toggle off its active status...»

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great catch, thank you!

rgilsimoes
rgilsimoes approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@rgilsimoes rgilsimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions to the text.

@sarah11918
Copy link
Member Author

!coauthor

@github-actions GitHub Actions
Copy link 

Co-authored-by: Houston (Bot) <108291165+astrobot-houston@users.noreply.github.com>
Co-authored-by: Ricardo Jaime Gil Simões <ricardo.gil.simoes@gmail.com>
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>

@sarah11918 sarah11918 merged commit c17f8ab into main Apr 25, 2024
8 checks passed
@sarah11918 sarah11918 deleted the 4.7.0 branch April 25, 2024 10:35
@helmerdavila helmerdavila mentioned this pull request Apr 25, 2024
Merged
@huyikai huyikai mentioned this pull request Apr 26, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Apr 26, 2024
Merged
thomasbnt added a commit to thomasbnt/docs that referenced this pull request May 2, 2024
@thomasbnt
i18n(fr): Update guides/dev-toolbar.mdx from withastro#8002
b2b5bcb 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt thomasbnt mentioned this pull request May 2, 2024
Merged
thomasbnt added a commit to thomasbnt/docs that referenced this pull request May 2, 2024
@thomasbnt
i18n(fr): Update integrations/cli-reference.mdx from withastro#8002
7b24f1e 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt thomasbnt mentioned this pull request May 2, 2024
Merged
dreyfus92 added a commit that referenced this pull request May 4, 2024
@thomasbnt @dreyfus92
i18n(fr): Update guides/dev-toolbar.mdx from #8002 (#8154)
5d2cdf7 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
dreyfus92 added a commit that referenced this pull request May 4, 2024
@thomasbnt @dreyfus92
i18n(fr): Update integrations/cli-reference.mdx from #8002 (#8159)
fc5a4c1 
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
@sarah11918 @Princesseuh
@rgilsimoes @wpplumber
4.7.0 minor release (withastro#8002)
abfeed2 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
Co-authored-by: Ricardo Jaime Gil Simões <ricardo.gil.simoes@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
@thomasbnt @dreyfus92 @wpplumber
i18n(fr): Update guides/dev-toolbar.mdx from withastro#8002 (withas…
b35b755 
…tro#8154)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 9, 2024
@thomasbnt @dreyfus92 @wpplumber
i18n(fr): Update integrations/cli-reference.mdx from withastro#8002 (…
d181492 
…withastro#8159)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@sarah11918 @Princesseuh
@rgilsimoes @wpplumber
4.7.0 minor release (withastro#8002)
225f5d0 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
Co-authored-by: Ricardo Jaime Gil Simões <ricardo.gil.simoes@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@thomasbnt @dreyfus92 @wpplumber
i18n(fr): Update guides/dev-toolbar.mdx from withastro#8002 (withas…
b9f7f71 
…tro#8154)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@thomasbnt @dreyfus92 @wpplumber
i18n(fr): Update integrations/cli-reference.mdx from withastro#8002 (…
08a05fa 
…withastro#8159)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@sarah11918 @Princesseuh
@rgilsimoes @wpplumber
4.7.0 minor release (withastro#8002)
9192e52 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
Co-authored-by: Ricardo Jaime Gil Simões <ricardo.gil.simoes@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@thomasbnt @dreyfus92 @wpplumber
i18n(fr): Update guides/dev-toolbar.mdx from withastro#8002 (withas…
f8da1d5 
…tro#8154)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@thomasbnt @dreyfus92 @wpplumber
i18n(fr): Update integrations/cli-reference.mdx from withastro#8002 (…
8d2bd51 
…withastro#8159)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
@ArmandPhilippot ArmandPhilippot mentioned this pull request Jun 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgilsimoes rgilsimoes rgilsimoes approved these changes

Assignees
No one assigned
Labels
merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sarah11918 @astrobot-houston @rgilsimoes @Princesseuh