-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update guidance on named slots in framework components #824
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Just one sentence commented above, otherwise, LGTM. @Jutanium - care to provide a DINM? (Dan is not mad.) |
Out of Astro time for today for a full review + comments. DINM, but instead of destructuring the props, consider accepting EDIT: To be clear, this DOES WORK in Solid, as these props are static elements. It's just not idiomatic to write it this way! |
Update branch, to appease the Hippo checks, and LGTM! Thanks Nate! 💜 |
What kind of changes does this PR include?
Description