Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update guidance on named slots in framework components #824

Merged
merged 5 commits into from
Jun 24, 2022
Merged

Conversation

natemoo-re
Copy link
Member

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)
  • New or updated content
  • Translated content
  • Changes to the docs site code
  • Something else!

Description

@netlify
Copy link

netlify bot commented Jun 23, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 86c2ba2
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/62b60c5ae4a75e0009ac6562
😎 Deploy Preview https://deploy-preview-824--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@sarah11918
Copy link
Member

Just one sentence commented above, otherwise, LGTM.

@Jutanium - care to provide a DINM? (Dan is not mad.)

@Jutanium
Copy link
Contributor

Jutanium commented Jun 23, 2022

Out of Astro time for today for a full review + comments. DINM, but instead of destructuring the props, consider accepting props as the parameter and refer to props.title, props.children etc, because this works in all the JSX frameworks (destructuring loses reactivity in Solid).

EDIT: To be clear, this DOES WORK in Solid, as these props are static elements. It's just not idiomatic to write it this way!

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Jun 23, 2022
@sarah11918
Copy link
Member

Update branch, to appease the Hippo checks, and LGTM! Thanks Nate! 💜

@natemoo-re natemoo-re merged commit 6f131d3 into main Jun 24, 2022
@natemoo-re natemoo-re deleted the named-slots branch June 24, 2022 19:26
yanthomasdev added a commit that referenced this pull request Jun 25, 2022
yanthomasdev added a commit that referenced this pull request Jun 30, 2022
…ges (#819)

* Update `astro-components.md` based on #778 changes

* Add #824 changes

* Fix

* Apply suggestions

Co-authored-by: victor0x16 <100092662+victor0x16@users.noreply.github.com>

Co-authored-by: victor0x16 <100092662+victor0x16@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants