Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(pt-BR): Update astro-components.md based on #778 and #824 changes #819

Merged
merged 6 commits into from
Jun 30, 2022
Merged

i18n(pt-BR): Update astro-components.md based on #778 and #824 changes #819

merged 6 commits into from
Jun 30, 2022

Conversation

yanthomasdev
Copy link
Member

@yanthomasdev yanthomasdev commented Jun 22, 2022 •
edited
Loading

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)
  • New or updated content
  • Translated content
  • Changes to the docs site code
  • Something else!

Description

Updated PT-BR astro-components.md page based on #778 and #824 changes.

@netlify
Copy link

netlify bot commented Jun 22, 2022 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 44309a5
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/62be28106824c500092d86a2
😎 Deploy Preview https://deploy-preview-819--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@delucis delucis added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 22, 2022
@yanthomasdev yanthomasdev changed the title i18n(pt-BR): Update astro-components.md based on #778 changes i18n(pt-BR): Update astro-components.md based on #778 and #824 changes Jun 25, 2022
ghost
ghost suggested changes Jun 30, 2022
View reviewed changes
Copy link

@ghost ghost left a comment •
edited by ghost
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yan-Thomas , have you split the PR? Because I think framework-components page is missing.

src/pages/pt-br/core-concepts/astro-components.md Outdated Show resolved Hide resolved
@yanthomasdev
Copy link
Member Author

Hi @victor0x16. Yes, I moved the framework-components.md changes to #842 (that is already merged). I generally go on a one PR per page basis, sorry for not being clear about this!

yanthomasdev and others added 2 commits June 30, 2022 19:47
@yanthomasdev
Apply suggestions
898cc8b 
Co-authored-by: victor0x16 <100092662+victor0x16@users.noreply.github.com>
@yanthomasdev
Merge branch 'main' into yan/i18n-astro-components
44309a5
@yanthomasdev
Copy link
Member Author

Thanks for all the reviews @victor0x16! 🚀

@yanthomasdev yanthomasdev merged commit 19e7e5d into main Jun 30, 2022
@yanthomasdev yanthomasdev deleted the yan/i18n-astro-components branch June 30, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanthomasdev @delucis