Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Lit with decorators usage example #8270

Merged
merged 7 commits into from
May 14, 2024

Conversation

liruifengv
Copy link
Sponsor Member

@liruifengv liruifengv commented May 14, 2024

Description (required)

Added Lit with TypeScript usage example

When you want use TypeScript decorators in Lit component, need to enable experimentalDecorators in tsconfig.json

Related issues & labels (optional)

  • Closes #
  • Suggested label:

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 14, 2024 1:05pm

@liruifengv liruifengv added the improve documentation Enhance existing documentation (e.g. add an example, improve description) label May 14, 2024
@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 14, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/integrations-guide/lit.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @liruifengv ! This looks like a great example to add!

I did have a question whether this is really a section that should be called "TypeScript" because it seems to be about adding the ability to use decorators, which require TypeScript. Let me know what the actual intention is, and we can adjust the wording slightly to fit in either case! 🙌

src/content/docs/en/guides/integrations-guide/lit.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/integrations-guide/lit.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/integrations-guide/lit.mdx Outdated Show resolved Hide resolved
liruifengv and others added 3 commits May 14, 2024 19:52
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@liruifengv liruifengv changed the title Added Lit with TypeScript usage example Added Lit with decorators usage example May 14, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little extra space, otherwise this is ready to go! Thank you for a great contribution!

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@liruifengv liruifengv added Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels May 14, 2024
@liruifengv liruifengv merged commit 58bdbd8 into withastro:main May 14, 2024
8 checks passed
@liruifengv liruifengv deleted the patch-lit branch May 14, 2024 13:18
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
* Added Lit with TypeScript example

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

---------

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
* Added Lit with TypeScript example

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

---------

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
* Added Lit with TypeScript example

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

* Update src/content/docs/en/guides/integrations-guide/lit.mdx

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>

---------

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
thomasbnt added a commit to thomasbnt/docs that referenced this pull request Jun 25, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
yanthomasdev added a commit that referenced this pull request Jun 25, 2024
* i18n(fr): Update guides/astro-db from #8478

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/backend from #8450

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/backend/google-firebase from #8422

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/cms/apostrophecms from #8480

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/cms/builderio from #8259

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/cms/directus from #8647

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/cms/ghost from #8518

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/cms/statamic from #7119

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/content-collections from #8447

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/data-fetching from #8210

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/deploy/cloudflare from #8421

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/deploy/netlify from #8233

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/deploy/render from #8233

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/deploy/vercel from #8217 (and fix little typos)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/environment-variables from #8533

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/environment-variables from #8611

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/images from #8447 #8646

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/integrations-guide from #8575

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/integrations-guide/cloudflare from #8211

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/integrations-guide/lit from #8270

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/integrations-guide/markdoc from #8167 (Steeeeps)

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/integrations-guide/preact from #8644

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/integrations-guide/react from #8038

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/integrations-guide/vue from #8295

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/markdown-content from #7218

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/markdown-content from #8167 #8239

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/middleware from #8572

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/prefetch from #8246

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/routing from #8466

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/rss from #8632

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/testing from #8369

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update guides/view-transitions from #8646

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Fix typo in routing.mdx

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Fix links ?

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Fix badge

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Fix badge

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Fix tabs

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Fix tabs

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* Update src/content/docs/fr/guides/environment-variables.mdx

Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com>

* Update src/content/docs/fr/guides/integrations-guide/lit.mdx

Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com>

* Update src/content/docs/fr/guides/integrations-guide/vue.mdx

Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com>

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com>

* Update src/content/docs/fr/guides/middleware.mdx

Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com>

* Update src/content/docs/fr/guides/testing.mdx

Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com>

* i18n(fr): Fix links

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): Update `tutorial/6-islands` because CI links err

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): fix links

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

* i18n(fr): fix links

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: pioupia <49518790+pioupia@users.noreply.github.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants