-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[reorg] New sidebar! #8239
[reorg] New sidebar! #8239
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, I am back! This is truly awesome. Thank you for spearheading this.
I added some comments about wording and suggested the addition of a sentence. I also made some edits for consistency's sake for sidebar title formatting!
Hope it helps!
possibly slightly re-order the upper-level sections to be like this:
I bumped up “Manage your Content” and “Assets” because I personally need to reference them more. Creating routes I only need IF I’m doing dynamic routing. I also noticed that image and asset topics seem to pop up more in support than routing it feels like. |
Thank you, @lorenzolewis - will play with this idea and see how it feels! |
Co-authored-by: voxel!() <voxelmc@hotmail.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spotted a couple of details in the redirects!
vercel.json
Outdated
{ "source": "/en/quick-start/", "destination": "/en/installation/" }, | ||
{ "source": "/en/quick-start/", "destination": "/en/install-and-setup/" }, | ||
|
||
{ "source": "/en/installation/", "destination": "/en/install-and-setup/" }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this added? I don’t see a current /installation/
link in use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was preexisting, and I thought it better to update to be safe? I'm not sure anyone might still be linking to quick-start
at this point, but I noticed it pointing to something so thought I should update the link in the chain.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
!coauthor |
|
Before merging, do not forget:
|
This PR attempts to tame our wild sidebar!
The goals of this PR:
Non-goals of this PR right now (although they could be future goals!)
Notable strategies I have taken with this PR:
Changing from headings emphasizing content type to headings describing topics included.
Rethinking the "new user journey".
#8415
Eliminating some things from the sidebar nav entirely
Tasks to complete
/recipes/
->en/community-resources/content/#official-recipes
andinstall/auto
/install/manual
->installation-and-setup
andaliases
->imports
isSubPage
logic so the right page in the sidebar nav is highlighted for non-entriesinstall/auto
,install/manual
, andrecipes
in non-EN languages so that translators can use the contentPRs that must merge first
imports.mdx
#8515Closes Issues