-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new install and setup page #8415
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just dropped some suggestions.
Thank you @rgilsimoes ! You've identified some areas that could be improved for sure! I am taking some of these suggestions and there's one I'll have to think a little harder about, since I think it probably needs a bit more of a rewrite! 🙌 |
Co-authored-by: Ricardo Jaime Gil Simões <ricardo.gil.simoes@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small comments, otherwise LGTM!
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
* Translate install-and-setup.mdx (added in withastro#8415) in French
* Translate install-and-setup.mdx (added in withastro#8415) in French
* i18n(fr): add install-and-setup.mdx * Translate install-and-setup.mdx (added in #8415) in French * i18n(fr): fix anchor links referring to install-and-setup.mdx Some French pages uses anchors in the `install-and-setup` page. Since I have translated the page, the anchors was broken. --------- Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Description (required)
This PR is in advance prep for sidebar reorg PR #8239 and attempts to provide more a more complete picture of "getting started" with a new project (without being overly long or overwhelming). The intention is to set users up for success on this one page, vs needing to click several pages before they are actually working successfully on their project.
It creates a new page to eventually replace the Auto Install page (and manual page) to include:
This PR separates out the new content from the sidebar nav changes that will happen later.
Notably, this does NOT perform all the housekeeping tasks like deleting the manual install page, moving anything out of the sidebar that is now mentioned on this page etc. It's just to keep the "big" sidebar PR to minimum content changes, and allow the translators to translate content separately!