Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(hi): update manual setup.mdx #1111

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

at-the-vr
Copy link
Member

Description

  • translate manual-setup page for Hindi language
  • fix minor punctuation typo for Starlight UI in Hindi section

Copy link

changeset-bot bot commented Nov 22, 2023

🦋 Changeset detected

Latest commit: 4c58daa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Nov 23, 2023 5:25pm

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Nov 22, 2023
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist and everything looks good to me 👍

Regarding the UI translation, my basic translation tool could not see any difference with or without the change so you're the best suited to know what's best 👍

Small note for you if you want to add one or the maintainer merging this PR: I think this would need a changeset as small as the change is.

@at-the-vr
Copy link
Member Author

Thanks for the translation 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist and everything looks good to me 👍

Regarding the UI translation, my basic translation tool could not see any difference with or without the change so you're the best suited to know what's best 👍

Small note for you if you want to add one or the maintainer merging this PR: I think this would need a changeset as small as the change is.

Apologies for the UI change, I am not aware of this changeset and its consequences but as long as its OK I am good 😄
Thanks for the review I will just add the Hindi Wikipedia link for the punctuations just for verification purposes (Note: how the full stop is shown as |)

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation @at-the-vr and for the review @HiDeoo!

The “changeset” HiDeoo mentioned is a short description of what changed and we need it when we make changes to anything in the packages/ directory. The concept comes from https://github.com/changesets/changesets/ — the library we use to manage releases.

In this case, it is needed because hi.json is not just used in our docs site, but shipped to all Starlight users, so when we change it, we want to make a new Starlight release. That way people updating Starlight get the updated punctuation if they’re using Hindi in their sites.

I can add the changeset now so we can merge this. Thanks again @at-the-vr!

@delucis delucis merged commit cb19d07 into withastro:main Nov 23, 2023
7 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Nov 23, 2023
@at-the-vr at-the-vr deleted the atv/i18n/hi/manual-setup branch December 9, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants