-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(hi): update manual setup.mdx
#1111
Conversation
🦋 Changeset detectedLatest commit: 4c58daa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the translation 🙌
As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist and everything looks good to me 👍
Regarding the UI translation, my basic translation tool could not see any difference with or without the change so you're the best suited to know what's best 👍
Small note for you if you want to add one or the maintainer merging this PR: I think this would need a changeset as small as the change is.
Apologies for the UI change, I am not aware of this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the translation @at-the-vr and for the review @HiDeoo!
The “changeset” HiDeoo mentioned is a short description of what changed and we need it when we make changes to anything in the packages/
directory. The concept comes from https://github.com/changesets/changesets/ — the library we use to manage releases.
In this case, it is needed because hi.json
is not just used in our docs site, but shipped to all Starlight users, so when we change it, we want to make a new Starlight release. That way people updating Starlight get the updated punctuation if they’re using Hindi in their sites.
I can add the changeset now so we can merge this. Thanks again @at-the-vr!
Description