-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(uk): Add Ukrainian language. #1295
Conversation
…`, `404.md`. Add Ukrainian to config files.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 433593c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Epic Start for Translating Starlight in Ukrainian
As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. I have couple of queries in form of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @juchym! Everything looks good to me apart from one heading @at-the-vr also asked about. Could you take a look above? Using Google Translate the “Troubleshooting Starlight” heading gets translated as “Insult Starlight”. This might just be a case of Google Translate getting things wrong, but would love a double check before merging!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @juchym! This should be good to go, I think. I updated the changeset to focus on the changes to uk.json
as the changeset ends up in the main Starlight package’s changelog.
One note: the Showcase page has changed its structure a little bit since you first made this PR. I’d love a follow-up PR to update that file to the new format if you have time!
Description
index.mdx
,getting-started.mdx
,showcase.mdx
,404.md
into Ukrainian. Add the locale to the necessary config files. Adjust some existing translations.