Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(uk): Add Ukrainian language. #1295

Merged
merged 6 commits into from
Jan 2, 2024
Merged

i18n(uk): Add Ukrainian language. #1295

merged 6 commits into from
Jan 2, 2024

Conversation

juchym
Copy link
Contributor

@juchym juchym commented Dec 18, 2023

Description

  • Translate index.mdx, getting-started.mdx, showcase.mdx, 404.md into Ukrainian. Add the locale to the necessary config files. Adjust some existing translations.

…`, `404.md`. Add Ukrainian to config files.
Copy link

vercel bot commented Dec 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Jan 2, 2024 6:00pm

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: 433593c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Dec 18, 2023
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@juchym juchym changed the title Add Ukrainian i18n. i18n(uk): Add Ukrainian language. Dec 18, 2023
docs/package.json Outdated Show resolved Hide resolved
.github/labeler.yml Outdated Show resolved Hide resolved
docs/astro.config.mjs Outdated Show resolved Hide resolved
Copy link
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic Start for Translating Starlight in Ukrainian

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. I have couple of queries in form of comments.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @juchym! Everything looks good to me apart from one heading @at-the-vr also asked about. Could you take a look above? Using Google Translate the “Troubleshooting Starlight” heading gets translated as “Insult Starlight”. This might just be a case of Google Translate getting things wrong, but would love a double check before merging!

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @juchym! This should be good to go, I think. I updated the changeset to focus on the changes to uk.json as the changeset ends up in the main Starlight package’s changelog.

One note: the Showcase page has changed its structure a little bit since you first made this PR. I’d love a follow-up PR to update that file to the new format if you have time!

@delucis delucis merged commit c3732a9 into withastro:main Jan 2, 2024
8 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants