Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates Korean UI translations #1487

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Updates Korean UI translations #1487

merged 2 commits into from
Feb 12, 2024

Conversation

NavyStack
Copy link
Contributor

Description

  • Closes #
  • What does this PR change? Give us a brief description.
  • Did you change something visual? A before/after screenshot can be helpful.
  1. Rearranged the word order to better match Korean sentiment.
  2. Rearranged the sentence structure to accommodate the Korean subject marker.
  3. We have striven to maintain the original sentence structure as closely as possible.
  4. Removed double-passive expressions that are commonly found in Korean translations.
  5. Attempts to express the intent of the original text to the best of its ability.

Copy link

changeset-bot bot commented Feb 11, 2024

🦋 Changeset detected

Latest commit: 6d28c04

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Feb 12, 2024 2:14pm

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Feb 11, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@NavyStack
Copy link
Contributor Author

If we understand correctly, 'On this page' refers to the unique component of 'Astro Islands', right?

In that case, 'On this page' should be translated into Korean as '이 페이지에서는'.
The existing Korean word '목차' simply means 'Table of contents' in English.

@delucis
Copy link
Member

delucis commented Feb 12, 2024

Thank for the PR @NavyStack!

@jsparkdev Would you be able to review this?

Copy link
Contributor

@jsparkdev jsparkdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여러 명이 모여서 오픈 소스에 기여를 하는 팀이신가 보네요!

PR 감사합니다.

"search.cancelLabel": "취소",
"search.devWarning": "검색 기능은 프로덕션 환경에서만 사용할 수 있습니다.\n사이트를 로컬 환경에서 테스트하기 위해 빌드하고 미리보기(Preview) 하세요.",
"search.devWarning": "검색 기능은 운영 환경에서만 사용할 수 있습니다. \n로컬에서 테스트하려면 사이트를 빌드하고 미리보기를 해보세요.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프로덕션 환경을 운영 환경이라고 번역하신 이유가 있으실까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프로덕션 환경을 운영 환경이라고 번역하신 이유가 있으실까요?

"운영 환경"이라는 번역은 "production environment"을 의미합니다.
프로덕션 환경이라는 용어는 소프트웨어나 서비스가 실제로 사용되고 있는 환경을 가리키는 것으로, 일반적으로 사용자들에게 서비스되는 환경을 의미합니다.

따라서 "운영 환경"이라는 번역은 이러한 문맥을 잘 전달하고 있습니다. "운영 환경"은 소프트웨어나 서비스가 실제로 운영되는 환경을 강조하는 것입니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네, 두 용어는 같은 의미를 가지기 때문에 문제가 없는 것 같습니다.

"tableOfContents.overview": "개요",
"i18n.untranslatedContent": "이 컨텐츠는 아직 번역되지 않았습니다.",
"i18n.untranslatedContent": "이 내용은 아직 번역본이 없습니다.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컨텐츠를 내용이라고 번역하신 이유가 있으실까요?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

컨텐츠를 내용이라고 번역하신 이유가 있으실까요?

국립국어원의 의견에 따르면

순화 이력에 따르면 '콘텐츠'에 대한 순화어가 명확히 마련되어 있지는 않습니다.
다만 '콘텐츠'가 포함된 복합 용어가 순화된 이력이 있는데, 경우에 따라 '콘텐츠'를 그대로 사용하기도 하고 '제작물'을 사용하기도 합니다.

고민을 많이 한 부분인데, 각 스트링별로 모듈화가 되어있어서, 콘텐츠 보다는 내용이 적합하다 생각했습니다.
또한 올바른 표기법은 외래어 표기법은 컨텐츠가 아닌 콘텐츠로 표기하는 것이 바릅니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네, 콘텐츠가 맞는 표기입니다. 내용과 큰 차이는 없는 것 같습니다.

"themeSelect.auto": "자동",
"languageSelect.accessibleLabel": "언어 선택",
"menuButton.accessibleLabel": "메뉴",
"sidebarNav.accessibleLabel": "메인",
"tableOfContents.onThisPage": "목차",
"tableOfContents.onThisPage": "이 페이지에서는",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우측 사이드바의 제목을 나타내므로 목차가 어울린다고 생각합니다.

혹시 이 페이지에서는 이라고 번역하신 이유가 있으실까요?

Copy link
Contributor Author

@NavyStack NavyStack Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우측 사이드바의 제목을 나타내므로 목차가 어울린다고 생각합니다.

혹시 이 페이지에서는 이라고 번역하신 이유가 있으실까요?


If we understand correctly, 'On this page' refers to the unique component of 'Astro Islands', right?

In that case, 'On this page' should be translated into Korean as '이 페이지에서는'. The existing Korean word '목차' simply means 'Table of contents' in English.

We might not be well-versed in the nuances of House style, but if it involves conversing in the translated language, then we'll certainly abide by it.

원 의도가 아스트로 아일랜드 아키텍쳐 이야기하는 것이라면 이 페이지에서는이 더 올바릅니다.
말 그대로 'On this page'의 번역이니까요.

만약 목차를 의미하는 것이었다면, 'Table of contents'와 비슷한 의미로 문자열을 구성했을 겁니다.
PR에 코멘트를 작성한 내용입니다.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NavyStack
Copy link
Contributor Author

NavyStack commented Feb 12, 2024

We might not be well-versed in the nuances of House style, but if it involves conversing in the translated language, then we'll certainly abide by it.

Copy link
Contributor

@jsparkdev jsparkdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다!

LGTM

@NavyStack
Copy link
Contributor Author

@jsparkdev 여러 번역에 참여하고 계신데,
선생님 덕분에 도움 많이 받았습니다.
앞으로도 자주 뵈었으면 좋겠습니다.

하루 마무리 잘 하세요 :)

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for the PR @NavyStack and for the thorough review @jsparkdev — great team work 💖

@delucis delucis added the 🌟 patch Change that triggers a patch release label Feb 12, 2024
@delucis delucis changed the title Update ko.json Updates Korean UI translations Feb 12, 2024
@delucis delucis merged commit 6a72bda into withastro:main Feb 12, 2024
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Feb 12, 2024
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Feb 20, 2024
* main: (126 commits)
  [ci] format
  [ci] release (withastro#1488)
  Fix rendering issue for text with unhandled Markdown directives (withastro#1489)
  i18n(es): update community-content (withastro#1493)
  i18n(es): update manual-setup (withastro#1492)
  Updates Korean UI translations (withastro#1487)
  i18n(fr): update `manual-setup` (withastro#1484)
  [ci] format
  i18n(ko-KR): update `manual-setup.mdx` (withastro#1482)
  i18n(ko-KR): update `community-content.mdx` (withastro#1483)
  [ci] format
  [ci] release (withastro#1481)
  [ci] format
  Make Starlight compatible with server output mode (withastro#1454)
  [i18nIgnore] community content: article description copy edit (withastro#1408)
  [ci] format
  i18n(it): Updated plugins.md and community-content.mdx (withastro#1480)
  i18n(fr): update `resources/community-content` (withastro#1479)
  [ci] format
  i18n(it): Modified everything in the /guides folder (withastro#1456)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants