Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] community content: article description copy edit #1408

Merged
merged 4 commits into from
Feb 9, 2024
Merged

[docs] community content: article description copy edit #1408

merged 4 commits into from
Feb 9, 2024

Conversation

olets
Copy link
Contributor

@olets olets commented Jan 24, 2024 •
edited

Description

You included my Starlight vs VuePress comparison in the community content page. Thanks!

There was a typo in the description.

The first commit fixes the typo.

The second two are a naive pass at correcting the existing localizations. I do not speak French or Korean, so used Google Translate. Google Translate translates the "before" English into the "before" French and Korean, making me think it's getting it right — or perhaps that the "before" translation was also done with Google Translate.

(There is also a Chinese localization. Running the "after" English through Google Translate results in no change in the translation.)

//

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2024 •
edited

⚠️ No Changeset found

Latest commit: 7938c32

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 24, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Feb 9, 2024 8:10pm

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Jan 24, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@github-actions github-actions bot removed the i18n Anything to do with internationalization & translation efforts label Feb 9, 2024
delucis
delucis approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update (and the article!) @olets.

I’ve made this a “typo fix” change only to the English version as we usually avoid updating multiple languages at once so we defer to our translators for that.

@delucis delucis merged commit 56fd72e into withastro:main Feb 9, 2024
9 checks passed
@jsparkdev jsparkdev mentioned this pull request Feb 10, 2024
Merged
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Feb 10, 2024
@HiDeoo
Merge branch 'main' into hd-virtual-pages
2107f4a 
* main: (96 commits)
  [ci] format
  i18n(ko-KR): update `manual-setup.mdx` (withastro#1482)
  i18n(ko-KR): update `community-content.mdx` (withastro#1483)
  [ci] format
  [ci] release (withastro#1481)
  [ci] format
  Make Starlight compatible with server output mode (withastro#1454)
  [i18nIgnore] community content: article description copy edit (withastro#1408)
  [ci] format
  i18n(it): Updated plugins.md and community-content.mdx (withastro#1480)
  i18n(fr): update `resources/community-content` (withastro#1479)
  [ci] format
  i18n(it): Modified everything in the /guides folder (withastro#1456)
  i18n(it): Modified frontmatter.md and overrides.md (withastro#1457)
  i18n(es): fix syntax highlighting with `diff`-like syntax example (withastro#1477)
  Add CodingCat.dev stream video to community content page (withastro#1475)
  i18n(fr): fix frontmatter `label` default value translation (withastro#1476)
  [ci] format
  [ci] release (withastro#1474)
  Set default color theme in template (withastro#1473)
  ...
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Feb 20, 2024
@HiDeoo
Merge branch 'main' into hd-file-tree
4aecb0c 
* main: (126 commits)
  [ci] format
  [ci] release (withastro#1488)
  Fix rendering issue for text with unhandled Markdown directives (withastro#1489)
  i18n(es): update community-content (withastro#1493)
  i18n(es): update manual-setup (withastro#1492)
  Updates Korean UI translations (withastro#1487)
  i18n(fr): update `manual-setup` (withastro#1484)
  [ci] format
  i18n(ko-KR): update `manual-setup.mdx` (withastro#1482)
  i18n(ko-KR): update `community-content.mdx` (withastro#1483)
  [ci] format
  [ci] release (withastro#1481)
  [ci] format
  Make Starlight compatible with server output mode (withastro#1454)
  [i18nIgnore] community content: article description copy edit (withastro#1408)
  [ci] format
  i18n(it): Updated plugins.md and community-content.mdx (withastro#1480)
  i18n(fr): update `resources/community-content` (withastro#1479)
  [ci] format
  i18n(it): Modified everything in the /guides folder (withastro#1456)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@olets @astrobot-houston @delucis