Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(zh-tw): add Traditional Chinese UI translations #1504

Merged
merged 3 commits into from
Feb 20, 2024
Merged

i18n(zh-tw): add Traditional Chinese UI translations #1504

merged 3 commits into from
Feb 20, 2024

Conversation

mingjunlu
Copy link
Contributor

@mingjunlu mingjunlu commented Feb 17, 2024 •
edited
Loading

Description

  • Adds Traditional Chinese UI translations

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1b3345f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Feb 20, 2024 6:31pm

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Feb 17, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@delucis
Copy link
Member

delucis commented Feb 17, 2024

Thanks for opening this PR @mingjunlu! I noticed you marked it as a draft. Let me know when it's ready for review 🙌

@mingjunlu mingjunlu marked this pull request as ready for review February 17, 2024 13:29
@mingjunlu
Copy link
Contributor Author

Good to go! Thanks for checking on this, @delucis 😊

@liruifengv
Copy link
Sponsor Member

liruifengv commented Feb 18, 2024 •
edited
Loading

Thanks for add this. @mingjunlu

Could you also add a changeset to this PR? You should be able to use the “Click here if you're a maintainer who wants to add a changeset to this PR” link in the Changeset comment or run pnpm changeset to use the CLI locally.

@mingjunlu
Copy link
Contributor Author

@liruifengv Sure, changeset added.

liruifengv
liruifengv approved these changes Feb 18, 2024
View reviewed changes
Copy link
Sponsor Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks! @mingjunlu

delucis
delucis approved these changes Feb 18, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @mingjunlu! And thanks for reviewing @liruifengv 💖

@delucis delucis added the 🌟 patch Change that triggers a patch release label Feb 18, 2024
@delucis delucis merged commit fc83a05 into withastro:main Feb 20, 2024
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Feb 20, 2024
Merged
@mingjunlu mingjunlu deleted the zh-tw/ui-translation branch February 21, 2024 07:26
log101 pushed a commit to log101/starlight that referenced this pull request Feb 23, 2024
@mingjunlu @liruifengv
@delucis @log101
i18n(zh-tw): add Traditional Chinese UI translations (withastro#1504)
d76dd8c 
Co-authored-by: liruifengv <25167721+liruifengv@users.noreply.github.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Feb 23, 2024
@HiDeoo
Merge branch 'main' into hd-file-tree
23f6727 
* main: (21 commits)
  i18n(ja): Update plugins.mdx (withastro#1550)
  [ci] format
  docs: Added Portuguese (pt-PT) language (withastro#1503)
  [ci] format
  i18n(fr): Update pages.mdx and plugins.mdx (withastro#1545)
  i18n(hi): update outdated pages (withastro#1539)
  i18n(es): Update getting-started.mdx (withastro#1531)
  [ci] format
  i18n(es): add "pages" page (withastro#1537)
  i18n(hi): add `customization.mdx` (withastro#1538)
  Update Vietnamese UI translations (withastro#1544)
  [ci] format
  [ci] release (withastro#1540)
  Improve DX for `sidebar` prop in `<StarlightPage>` and document it (withastro#1534)
  i18n(zh-tw): add Traditional Chinese UI translations (withastro#1504)
  Export `StarlightPageProps` type (withastro#1527)
  [ci] format
  Add new starlight-ghostcms to Community plugins list (withastro#1536)
  docs: Add more plugins & tools (withastro#1528)
  [ci] format
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

@liruifengv liruifengv liruifengv approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mingjunlu @astrobot-houston @delucis @liruifengv