Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export StarlightPageProps type #1527

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Feb 18, 2024

What kind of changes does this PR include?

  • Changes to Starlight code

Description

As I mentioned on Discord, and a bit similar to #1278, this pull request exports the new StarlightPageProps type as I found myself wanting to use it in TS files a few times when converting some integrations injecting pages to Starlight plugins.

Copy link

changeset-bot bot commented Feb 18, 2024

🦋 Changeset detected

Latest commit: 0edbefb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Feb 20, 2024 6:27pm

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HiDeoo!

@delucis delucis added the 🌟 patch Change that triggers a patch release label Feb 20, 2024
@delucis delucis merged commit 163bc84 into withastro:main Feb 20, 2024
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Feb 20, 2024
log101 pushed a commit to log101/starlight that referenced this pull request Feb 23, 2024
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Feb 23, 2024
* main: (21 commits)
  i18n(ja): Update plugins.mdx (withastro#1550)
  [ci] format
  docs: Added Portuguese (pt-PT) language (withastro#1503)
  [ci] format
  i18n(fr): Update pages.mdx and plugins.mdx (withastro#1545)
  i18n(hi): update outdated pages (withastro#1539)
  i18n(es): Update getting-started.mdx (withastro#1531)
  [ci] format
  i18n(es): add "pages" page (withastro#1537)
  i18n(hi): add `customization.mdx` (withastro#1538)
  Update Vietnamese UI translations (withastro#1544)
  [ci] format
  [ci] release (withastro#1540)
  Improve DX for `sidebar` prop in `<StarlightPage>` and document it (withastro#1534)
  i18n(zh-tw): add Traditional Chinese UI translations (withastro#1504)
  Export `StarlightPageProps` type (withastro#1527)
  [ci] format
  Add new starlight-ghostcms to Community plugins list (withastro#1536)
  docs: Add more plugins & tools (withastro#1528)
  [ci] format
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants