Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds starlight icon to Starlight #1698

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

liruifengv
Copy link
Sponsor Member

@liruifengv liruifengv commented Mar 30, 2024

Description

Adds starlight icon to Starlight

Copy link

changeset-bot bot commented Mar 30, 2024

🦋 Changeset detected

Latest commit: 37d8941

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Apr 1, 2024 0:14am

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Mar 30, 2024
@liruifengv liruifengv requested a review from delucis March 30, 2024 07:17
@liruifengv liruifengv changed the title Adds starlight icon for Starlight Adds starlight icon to Starlight Mar 30, 2024
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @liruifengv! Better late than never to add our own icon 😁

packages/starlight/components/Icons.ts Outdated Show resolved Hide resolved
@delucis delucis added the 🌟 patch Change that triggers a patch release label Apr 1, 2024
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@liruifengv
Copy link
Sponsor Member Author

image

I think it will be interesting if we update the docs!

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thank you @liruifengv 🌟

Re: your suggested the docs change — do you think it could be confusing to people? My only concern is if it might be a bit less obvious that the Starlight logo is an icon compared to the more generic star.

@delucis delucis merged commit 67b892f into withastro:main Apr 1, 2024
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Apr 1, 2024
@liruifengv
Copy link
Sponsor Member Author

star

Yeah. Star is good.

HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 5, 2024
* main: (111 commits)
  Fix various Expressive Code translation issues (withastro#1708)
  Fix nested aside title rendering issue (withastro#1703)
  I18n(pt-PT): Add resources pages (withastro#1678)
  Add SST Ion & Font Awesome to site showcase (withastro#1710)
  [ci] format
  Add SudoVanilla to showcase (withastro#1702)
  i18n(fr): Update `resources-showcase` (withastro#1697)
  [i18nIgnore] docs: update `starlight-links-validator` to version `0.7.1` (withastro#1696)
  [ci] format
  [ci] release (withastro#1688)
  [ci] format
  Update Russian translation (withastro#1616)
  [ci] format
  Adds `starlight` icon to Starlight (withastro#1698)
  Update Icons.ts with Farcaster Purple for SocialIcons (withastro#1622)
  Remove duplicate from showcase example in `contributing.md` (withastro#1692)
  i18n(zh-cn): Update `showcase.mdx` (withastro#1689)
  [ci] format
  i18n(zh-cn): Update configuration.mdx (withastro#1691)
  i18n(ko-KR): update `showcase.mdx` (withastro#1690)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants