Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Icons.ts with Farcaster Purple for SocialIcons #1622

Merged
merged 7 commits into from
Apr 1, 2024
Merged

Update Icons.ts with Farcaster Purple for SocialIcons #1622

merged 7 commits into from
Apr 1, 2024

Conversation

SamuelLHuber
Copy link
Contributor

Description

This PR adds farcaster.xyz to the options in the SocialIcons menu.

SVG for the icon can be found here https://github.com/vrypan/farcaster-brand/blob/main/icons/icon-transparent/transparent-purple.svg

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 0bc6a02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Mar 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Apr 1, 2024 0:10am

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Mar 18, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@delucis
Copy link
Member

delucis commented Mar 19, 2024

Hi @SamuelLHuber — thanks for the PR. Could you double check the SVG path you provided? I don’t see the icon showing up in the preview of the docs:

icon grid space labelled “farcaster” but it is empty

@SamuelLHuber
Copy link
Contributor Author

thank you for replying this quickly, appreciated.

this is the original SVG from the github source

<svg width="16" height="16" viewBox="0 0 1000 1000" fill="none" xmlns="http://www.w3.org/2000/svg">
<path d="M257.778 155.556H742.222V844.445H671.111V528.889H670.414C662.554 441.677 589.258 373.333 500 373.333C410.742 373.333 337.446 441.677 329.586 528.889H328.889V844.445H257.778V155.556Z" fill="#855DCD"/>
<path d="M128.889 253.333L157.778 351.111H182.222V746.667C169.949 746.667 160 756.616 160 768.889V795.556H155.556C143.283 795.556 133.333 805.505 133.333 817.778V844.445H382.222V817.778C382.222 805.505 372.273 795.556 360 795.556H355.556V768.889C355.556 756.616 345.606 746.667 333.333 746.667H306.667V253.333H128.889Z" fill="#855DCD"/>
<path d="M675.556 746.667C663.283 746.667 653.333 756.616 653.333 768.889V795.556H648.889C636.616 795.556 626.667 805.505 626.667 817.778V844.445H875.556V817.778C875.556 805.505 865.606 795.556 853.333 795.556H848.889V768.889C848.889 756.616 838.94 746.667 826.667 746.667V351.111H851.111L880 253.333H702.222V746.667H675.556Z" fill="#855DCD"/>
</svg>

which matches the one in the commit, unsure if that helps.

it is working with that exact svg on a overriden SocialIcons Header i have deployed

@delucis
Copy link
Member

delucis commented Mar 20, 2024

Ah yes, so that SVG has a viewBox of 1000×1000 pixels, but when used in Starlight, all icons need to be resized to 24×24. So by just bringing the whole path over, we’re looking at the top-left 24 px² and probably can’t see the full icon. Could you try resizing the icon down to 24×24 and then adding the resulting path?

@SamuelLHuber
Copy link
Contributor Author

check thank you resized using svgviewer.dev and commiting the resized svg now

full svg for reference

<svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M6.187 3.733h11.627v16.533h-1.707V12.693h-0.017c-0.189 -2.093 -1.948 -3.733 -4.09 -3.733s-3.901 1.64 -4.09 3.733h-0.017v7.573h-1.707z" fill="#855DCD"/><path d="m3.093 6.08 0.693 2.347h0.587v9.493c-0.295 0 -0.533 0.239 -0.533 0.533v0.64h-0.107c-0.295 0 -0.533 0.239 -0.533 0.533v0.64h5.973v-0.64c0 -0.295 -0.239 -0.533 -0.533 -0.533h-0.107v-0.64c0 -0.295 -0.239 -0.533 -0.533 -0.533h-0.64V6.08z" fill="#855DCD"/><path d="M16.213 17.92c-0.295 0 -0.533 0.239 -0.533 0.533v0.64h-0.107c-0.295 0 -0.533 0.239 -0.533 0.533v0.64h5.973v-0.64c0 -0.295 -0.239 -0.533 -0.533 -0.533h-0.107v-0.64c0 -0.295 -0.239 -0.533 -0.533 -0.533V8.427h0.587L21.12 6.08H16.853v11.84z" fill="#855DCD"/></svg>

@SamuelLHuber
Copy link
Contributor Author

shows up perfectly in preview now

@SamuelLHuber @HiDeoo
Update packages/starlight/components/Icons.ts
2dde47a 
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
@SamuelLHuber
Copy link
Contributor Author

let me know if it's good now, looks fine in preview

HiDeoo
HiDeoo approved these changes Mar 27, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the pull request 🙌

This is looking really great. I added a changeset file that will be used to describe the changes to users. This looks perfect to me.

Note that this PR won't be merged immediately but will be merged when the next release is made so that the documentation mentioning the new icon is only updated when the new icon is actually available.

@delucis delucis added the 🌟 patch Change that triggers a patch release label Apr 1, 2024
@delucis delucis merged commit 3a074ba into withastro:main Apr 1, 2024
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Apr 1, 2024
Merged
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 5, 2024
@HiDeoo
Merge branch 'main' into hd-draft-pages
dd2c68c 
* main: (111 commits)
  Fix various Expressive Code translation issues (withastro#1708)
  Fix nested aside title rendering issue (withastro#1703)
  I18n(pt-PT): Add resources pages (withastro#1678)
  Add SST Ion & Font Awesome to site showcase (withastro#1710)
  [ci] format
  Add SudoVanilla to showcase (withastro#1702)
  i18n(fr): Update `resources-showcase` (withastro#1697)
  [i18nIgnore] docs: update `starlight-links-validator` to version `0.7.1` (withastro#1696)
  [ci] format
  [ci] release (withastro#1688)
  [ci] format
  Update Russian translation (withastro#1616)
  [ci] format
  Adds `starlight` icon to Starlight (withastro#1698)
  Update Icons.ts with Farcaster Purple for SocialIcons (withastro#1622)
  Remove duplicate from showcase example in `contributing.md` (withastro#1692)
  i18n(zh-cn): Update `showcase.mdx` (withastro#1689)
  [ci] format
  i18n(zh-cn): Update configuration.mdx (withastro#1691)
  i18n(ko-KR): update `showcase.mdx` (withastro#1690)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SamuelLHuber @astrobot-houston @delucis @HiDeoo