Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(ru): update translations #1825

Merged
merged 5 commits into from
May 2, 2024
Merged

Conversation

dragomano
Copy link
Contributor

@dragomano dragomano commented May 2, 2024

Updates some translations:

  • ru/getting-started.mdx
  • ru/guides/components.mdx
  • ru/guides/css-and-tailwind.mdx
  • ru/guides/customization.mdx
  • ru/guides/pages.mdx
  • ru/reference/configuration.mdx
  • ru/reference/frontmatter.md
  • ru/reference/overrides.md
  • ru/resources/community-content.mdx

Copy link

changeset-bot bot commented May 2, 2024

⚠️ No Changeset found

Latest commit: 3598017

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview May 2, 2024 9:20am

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels May 2, 2024
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented May 2, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ru getting-started.mdx Localization changed, will be marked as complete.
ru guides/components.mdx Localization changed, will be marked as complete.
ru guides/css-and-tailwind.mdx Localization changed, will be marked as complete.
ru guides/customization.mdx Localization changed, will be marked as complete.
ru guides/i18n.mdx Localization changed, will be marked as complete.
ru guides/pages.mdx Localization changed, will be marked as complete.
ru reference/configuration.mdx Localization changed, will be marked as complete.
ru reference/frontmatter.md Localization changed, will be marked as complete.
ru reference/overrides.md Localization changed, will be marked as complete.
ru resources/community-content.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for another amazing translation 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. Left 2 tiny suggestions, but everything else looks perfect to me.

Comment on lines 161 to 167
+ en: 'My Docs',
+ ru: "Моя документация",
+ },
defaultLocale: 'ru',
locales: {
en: { label: 'English' },
ru: { label: 'Русский', lang: 'ru' },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in this case, it would better to keep the zh-CN example and replace en by ru. This is what we've been doing so far in other translations and the goal is to keep an example with a BCP 47 tag with a regional subtag as they can be tricky with zh-CN vs zh-cn.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing these changes from this PR and moving them to a new PR?

To explain the rationale, these UI string translations are shipped to the users, so they would need a changeset so that the change is described to users in our changelog. Considering the size of the changes to this file, I think it would be easier to move them to a new PR so that we can merge the documentation changes in this PR right away and the UI string changes in a new one.

Let me know if that sounds ok to you.

@github-actions github-actions bot removed the 🌟 core Changes to Starlight’s main package label May 2, 2024
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for the fast updates 👍

@HiDeoo HiDeoo merged commit e556b71 into withastro:main May 2, 2024
11 checks passed
@dragomano dragomano deleted the update_russian branch May 2, 2024 09:22
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request May 3, 2024
* main: (57 commits)
  Add type checking job to the CI workflow (withastro#1827)
  [ci] format
  i18n(pt-BR): Update `components.mdx` (withastro#1815)
  [ci] format
  i18n(ru): update translations (withastro#1825)
  i18n(pt-BR): Update `css-and-tailwind.mdx` (withastro#1817)
  i18n(es): updates `pages` (withastro#1823)
  i18n(es): update `i18n` (withastro#1822)
  i18n(es): updates `overrides` (withastro#1820)
  i18n(es): update `guides/components` and add `syncKey` to various pages (withastro#1818)
  [ci] format
  i18n(es): update `community-content` (withastro#1824)
  i18n(es): update `configuration` (withastro#1821)
  i18n(es): update `frontmatter` (withastro#1819)
  i18n(fr): update `guides/pages.mdx` (withastro#1800)
  i18n(fr): update `reference/overrides.md` (withastro#1803)
  i18n(fr): update `reference/frontmatter.md` (withastro#1802)
  i18n(fr): update `reference/configuration.mdx` (withastro#1801)
  i18n(fr): update `guides/i18n.mdx` (withastro#1799)
  i18n(fr): update `guides/components` and add `syncKey` to various pages (withastro#1797)
  ...
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request May 3, 2024
* main: (60 commits)
  Add type checking job to the CI workflow (withastro#1827)
  [ci] format
  i18n(pt-BR): Update `components.mdx` (withastro#1815)
  [ci] format
  i18n(ru): update translations (withastro#1825)
  i18n(pt-BR): Update `css-and-tailwind.mdx` (withastro#1817)
  i18n(es): updates `pages` (withastro#1823)
  i18n(es): update `i18n` (withastro#1822)
  i18n(es): updates `overrides` (withastro#1820)
  i18n(es): update `guides/components` and add `syncKey` to various pages (withastro#1818)
  [ci] format
  i18n(es): update `community-content` (withastro#1824)
  i18n(es): update `configuration` (withastro#1821)
  i18n(es): update `frontmatter` (withastro#1819)
  i18n(fr): update `guides/pages.mdx` (withastro#1800)
  i18n(fr): update `reference/overrides.md` (withastro#1803)
  i18n(fr): update `reference/frontmatter.md` (withastro#1802)
  i18n(fr): update `reference/configuration.mdx` (withastro#1801)
  i18n(fr): update `guides/i18n.mdx` (withastro#1799)
  i18n(fr): update `guides/components` and add `syncKey` to various pages (withastro#1797)
  ...
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request May 3, 2024
* main: (74 commits)
  Add type checking job to the CI workflow (withastro#1827)
  [ci] format
  i18n(pt-BR): Update `components.mdx` (withastro#1815)
  [ci] format
  i18n(ru): update translations (withastro#1825)
  i18n(pt-BR): Update `css-and-tailwind.mdx` (withastro#1817)
  i18n(es): updates `pages` (withastro#1823)
  i18n(es): update `i18n` (withastro#1822)
  i18n(es): updates `overrides` (withastro#1820)
  i18n(es): update `guides/components` and add `syncKey` to various pages (withastro#1818)
  [ci] format
  i18n(es): update `community-content` (withastro#1824)
  i18n(es): update `configuration` (withastro#1821)
  i18n(es): update `frontmatter` (withastro#1819)
  i18n(fr): update `guides/pages.mdx` (withastro#1800)
  i18n(fr): update `reference/overrides.md` (withastro#1803)
  i18n(fr): update `reference/frontmatter.md` (withastro#1802)
  i18n(fr): update `reference/configuration.mdx` (withastro#1801)
  i18n(fr): update `guides/i18n.mdx` (withastro#1799)
  i18n(fr): update `guides/components` and add `syncKey` to various pages (withastro#1797)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants