Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BlueSky social icon #1871

Merged
merged 4 commits into from
May 16, 2024
Merged

Add BlueSky social icon #1871

merged 4 commits into from
May 16, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented May 15, 2024

Description

  • Closes Add Bluesky Social #1853
  • Adds an icon for the BlueSky social network
  • Also adds it as a social link option
  • I decided to capitalise “Sky” in the API and accessible label to reflect the common understanding of the brand name as two words — “blue sky” — even though it appears canonically they use the unusual “Bluesky” casing (see some discussion on Mastodon).

@vercel Vercel
Copy link

vercel bot commented May 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview May 16, 2024 9:11pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
starlight-i18n ⬜️ Ignored (Inspect) May 16, 2024 9:11pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 15, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 5e9000f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label May 15, 2024
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented May 15, 2024 •
edited
Loading

size-limit report 📦

Path Size
/index.html 6.11 KB (0%)
/_astro/*.js 22.02 KB (0%)
/_astro/*.css 13.46 KB (0%)

@delucis delucis added the 🌟 patch Change that triggers a patch release label May 15, 2024
at-the-vr
at-the-vr approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with GitPod, works 💯 LGTM 👍

@delucis delucis merged commit 03bb126 into main May 16, 2024
11 checks passed
@delucis delucis deleted the chris/bluesky branch May 16, 2024 21:13
@astrobot-houston astrobot-houston mentioned this pull request May 16, 2024
Merged
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request May 20, 2024
@HiDeoo
Merge branch 'main' into hd-refactor-astro-i18n
897f0bf 
* main: (45 commits)
  i18n(tr): add `showcase.mdx` (withastro#1896)
  [ci] format
  i18n(zh-cn): Update `authoring-content.md` (withastro#1901)
  [ci] format
  [ci] release (withastro#1897)
  [ci] format
  i18n(tr): update `authoring-content.md` (withastro#1887)
  Micro-optimization: clean up `<details>` CSS (withastro#1892)
  [ci] format
  i18n(tr): update `components.md` file (withastro#1889)
  [ci] format
  i18n(tr): add css-and-tailwind (withastro#1893)
  [ci] format
  [ci] release (withastro#1890)
  Adds custom styles for `<details>` and `<summary>` elements in Markdown content (withastro#1735)
  Update @astrojs/mdx to v3 (withastro#1846)
  [ci] format
  [ci] release (withastro#1869)
  Add BlueSky social icon (withastro#1871)
  [ci] format
  ...
This was referenced Jun 6, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@at-the-vr at-the-vr at-the-vr approved these changes

Assignees
No one assigned
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delucis @astrobot-houston @at-the-vr