Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(tr): update components.md file #1889

Merged
merged 4 commits into from
May 18, 2024
Merged

i18n(tr): update components.md file #1889

merged 4 commits into from
May 18, 2024

Conversation

erkanaltinors
Copy link
Contributor

What kind of changes does this PR include?

Updates of Starlight docs site content

Description

This pull request updates translated in Turkish components.md file in project.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 17, 2024 •
edited

⚠️ No Changeset found

Latest commit: 1ce8469

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview May 18, 2024 10:59am

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels May 17, 2024
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented May 17, 2024 •
edited

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
tr guides/components.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

HiDeoo
HiDeoo requested changes May 18, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. I left a few tiny suggestions but this is looking pretty great 👍

docs/src/content/docs/tr/guides/components.mdx
@@ -65,18 +65,66 @@ Her `<TabItem>` bileşenini kullanıcılara göstermek için `label` sahibi olma
import { Tabs, TabItem } from '@astrojs/starlight/components';

<Tabs>
<TabItem label="Yıldızlar">Sirius, Vega, Betelgeuse</TabItem>
<TabItem label="Uydular">Io, Europa, Ganymede</TabItem>
<TabItem label="Yıldızlar" icon="star">Sirius, Vega, Betelgeuse</TabItem>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot leave a comment for the sentences above the example but it looks like this paragraph contains a few issues:

  • The "You can display a tabbed interface using the <Tabs> and <TabItem> components." is in English.
  • It's missing the icon attribute description and link

Would you mind taking a look at it and updating it?

docs/src/content/docs/tr/guides/components.mdx
@@ -164,23 +212,220 @@ import { LinkCard } from '@astrojs/starlight/components';
<LinkCard title="Bileşenler" href="/tr/guides/components/" />
</CardGrid>

### Ara bölümler

Ara bölümler (ayrıca "uyarı" ve "açıklama balonu" olarak da bilinir), sayfanın ana içeriği ile birlikte ikincil bilgi göstermek için kullanışlıdır.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ara bölümler (ayrıca "uyarı" ve "açıklama balonu" olarak da bilinir), sayfanın ana içeriği ile birlikte ikincil bilgi göstermek için kullanışlıdır.
Ara bölümler (ayrıca "uyarı" ve "açıklama balonu" olarak da bilinir), sayfanın ana içeriği ile birlikte ikincil bilgi göstermek için kullanışlıdır.

To match the English version

docs/src/content/docs/tr/guides/components.mdx
Özel bir başlık *ile* uyarı ara bölümü.
</Aside>

<Aside type="tip">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Aside type="tip">
<Aside type="tip">

Just to match the English version too

docs/src/content/docs/tr/guides/components.mdx Outdated
<Aside type="danger">Şifreni kimseye verme.</Aside>

Starlight, ayrıca `<Aside>` bileşenine alternatif olarak Markdown ve MDX içerisinde ara bölüm oluşturmak için özel bir sözdizimi sağlar.
Starlight also provides a custom syntax for rendering asides in Markdown and MDX as an alternative to the `<Aside>` component.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Starlight also provides a custom syntax for rendering asides in Markdown and MDX as an alternative to the `<Aside>` component.

Probably something missed

docs/src/content/docs/tr/guides/components.mdx Outdated
Comment on lines 366 to 368
`<Steps>` bileşenini numaralanmış görevler listesini biçimlendirmek için kullanın.

Her aşamasının açıkça belirtilmeye ihtiyaç duyan çok karmaşık adım adım rehberleri oluşturmak için kullanışlıdır.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`<Steps>` bileşenini numaralanmış görevler listesini biçimlendirmek için kullanın.
Her aşamasının açıkça belirtilmeye ihtiyaç duyan çok karmaşık adım adım rehberleri oluşturmak için kullanışlıdır.
`<Steps>` bileşenini numaralanmış görevler listesini biçimlendirmek için kullanın.
Her aşamasının açıkça belirtilmeye ihtiyaç duyan çok karmaşık adım adım rehberleri oluşturmak için kullanışlıdır.

To match the english version

docs/src/content/docs/tr/guides/components.mdx Outdated
Comment on lines 370 to 372
Standart Markdown sıralanmış listesini `<Steps>` bileşeni ile sarmalayın.

`<Steps>` bileşeni içerisinde tüm olağan Markdown sözdizimi uygulanabilir.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Standart Markdown sıralanmış listesini `<Steps>` bileşeni ile sarmalayın.
`<Steps>` bileşeni içerisinde tüm olağan Markdown sözdizimi uygulanabilir.
Standart Markdown sıralanmış listesini `<Steps>` bileşeni ile sarmalayın.
`<Steps>` bileşeni içerisinde tüm olağan Markdown sözdizimi uygulanabilir.

Same as above

docs/src/content/docs/tr/guides/components.mdx
Comment on lines +413 to +414
Her `<Icon>` [`name`](#tüm-i̇konlar) değerine ihtiyaç duyar ve isteğe bağlı olarak `label` eklenebilir.
`size` ve `color` nitelikleri ikonun görünümünü CSS birimleri ve renk değerleri ile ayarlamak için kullanılabilir.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Her `<Icon>` [`name`](#tüm-i̇konlar) değerine ihtiyaç duyar ve isteğe bağlı olarak `label` eklenebilir.
`size` ve `color` nitelikleri ikonun görünümünü CSS birimleri ve renk değerleri ile ayarlamak için kullanılabilir.
Her `<Icon>` [`name`](#tüm-i̇konlar) değerine ihtiyaç duyar ve isteğe bağlı olarak `label` eklenebilir.
`size` ve `color` nitelikleri ikonun görünümünü CSS birimleri ve renk değerleri ile ayarlamak için kullanılabilir.

@erkanaltinors
Copy link
Contributor Author

@HiDeoo I've applied all suggessted changes in last commit.

HiDeoo
HiDeoo approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HiDeoo I've applied all suggessted changes in last commit.

Perfect and super fast, thanks a lot for another great translation 🙌

@HiDeoo HiDeoo merged commit d06883a into withastro:main May 18, 2024
12 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request May 20, 2024
@HiDeoo
Merge branch 'main' into hd-refactor-astro-i18n
897f0bf 
* main: (45 commits)
  i18n(tr): add `showcase.mdx` (withastro#1896)
  [ci] format
  i18n(zh-cn): Update `authoring-content.md` (withastro#1901)
  [ci] format
  [ci] release (withastro#1897)
  [ci] format
  i18n(tr): update `authoring-content.md` (withastro#1887)
  Micro-optimization: clean up `<details>` CSS (withastro#1892)
  [ci] format
  i18n(tr): update `components.md` file (withastro#1889)
  [ci] format
  i18n(tr): add css-and-tailwind (withastro#1893)
  [ci] format
  [ci] release (withastro#1890)
  Adds custom styles for `<details>` and `<summary>` elements in Markdown content (withastro#1735)
  Update @astrojs/mdx to v3 (withastro#1846)
  [ci] format
  [ci] release (withastro#1869)
  Add BlueSky social icon (withastro#1871)
  [ci] format
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erkanaltinors @astrobot-houston @HiDeoo