Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Arabic translation UI #778

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

jermanuts
Copy link
Contributor

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

Improvements and changed some transliteration.

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023

🦋 Changeset detected

Latest commit: 71bc8c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 71bc8c3
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/651abeebdf6e780008296196
😎 Deploy Preview https://deploy-preview-778--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Sep 28, 2023
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @jermanuts! Would love someone who speaks Arabic to review these changes if possible.

In the meantime, would you mind giving a quick description of what was needed here and why? For example, explaining why داكن is preferable to ليلي, etc.

@X7md
Copy link

X7md commented Sep 29, 2023

Thank you for the PR @jermanuts! Would love someone who speaks Arabic to review these changes if possible.

In the meantime, would you mind giving a quick description of what was needed here and why? For example, explaining why داكن is preferable to ليلي, etc.

In Standard Arabic mostly you will see "داكن".

iOS:
image

@delucis
Copy link
Member

delucis commented Sep 29, 2023

Thanks for the input @X7md! Can you confirm the rest of the changes look good to you?

@X7md
Copy link

X7md commented Sep 29, 2023

Also google

IMG_3274

IMG_3273

@delucis
Copy link
Member

delucis commented Sep 29, 2023

Great! How about the other changes — https://github.com/withastro/starlight/pull/778/files ?
This PR changes a bunch, not just داكن.

@jermanuts
Copy link
Contributor Author

Great! How about the other changes — https://github.com/withastro/starlight/pull/778/files ? This PR changes a bunch, not just داكن.

You can check here https://mostalah.org/ type any word in english. Arabeyes are the best.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @jermanuts! Using machine translation, the changes seem OK (although the existing text also looks fine that way, so it’s a bit hard for me to judge if the changes are needed or not). Happy to include these though and hopefully people will let us know if they’re unhappy with any of these updates.

@delucis delucis added the 🌟 patch Change that triggers a patch release label Oct 2, 2023
@delucis delucis merged commit 957d2c3 into withastro:main Oct 2, 2023
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants