-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to Arabic translation UI #778
Conversation
🦋 Changeset detectedLatest commit: 71bc8c3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @jermanuts! Would love someone who speaks Arabic to review these changes if possible.
In the meantime, would you mind giving a quick description of what was needed here and why? For example, explaining why داكن
is preferable to ليلي
, etc.
In Standard Arabic mostly you will see "داكن". |
Thanks for the input @X7md! Can you confirm the rest of the changes look good to you? |
Great! How about the other changes — https://github.com/withastro/starlight/pull/778/files ? |
You can check here https://mostalah.org/ type any word in english. Arabeyes are the best. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @jermanuts! Using machine translation, the changes seem OK (although the existing text also looks fine that way, so it’s a bit hard for me to judge if the changes are needed or not). Happy to include these though and hopefully people will let us know if they’re unhappy with any of these updates.
What kind of changes does this PR include?
Description
Improvements and changed some transliteration.