Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove role="banner" from banner #781

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Conversation

dreyfus92
Copy link
Member

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)

Description

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2023

🦋 Changeset detected

Latest commit: fabf376

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit fabf376
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6515cc0e94933900086588de
😎 Deploy Preview https://deploy-preview-781--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Sep 28, 2023
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request 🙌

This may need a changeset, someone could have for some reason used a CSS selector like [role=banner]?

@dreyfus92
Copy link
Member Author

Thank you for the review @HiDeoo 😁

@delucis delucis added the 🌟 patch Change that triggers a patch release label Sep 28, 2023
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@delucis delucis changed the title Remove: remove role of banner Remove role="banner" from banner Sep 28, 2023
@delucis delucis merged commit a293ef9 into withastro:main Sep 28, 2023
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Sep 28, 2023
@dreyfus92 dreyfus92 deleted the updates-51 branch April 10, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants