Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add goreleaser spec #1096

Merged
merged 1 commit into from Apr 3, 2022
Merged

feat: add goreleaser spec #1096

merged 1 commit into from Apr 3, 2022

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Apr 2, 2022

Signed-off-by: Engin Diri engin.diri@mail.schwarz

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This PR adds the spec for goreleaser and fixes #1095

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Additional info:

@withfig-bot
Copy link
Collaborator

Overview

src/goreleaser.ts:

Info:

@withfig-bot
Copy link
Collaborator

Hello @dirien,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

fedeci
fedeci approved these changes Apr 2, 2022
View reviewed changes
Copy link
Contributor

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@caarlos0
Copy link
Contributor

caarlos0 commented Apr 2, 2022

Other completions are auto-generated... can we do the same for fig?

Also, fig will read from this repo? If so, what happens with different versions of goreleaser, which might have different flags/docs/etc?

@dirien
Copy link
Contributor Author

dirien commented Apr 2, 2022

@caarlos0 https://fig.io/docs/handbook/versioning-completion-specs you can consider this case during the creation of the Spec.

feat: Add GoReleaser Spec
b528226 
Signed-off-by: Engin Diri <engin.diri@mail.schwarz>
@fedeci
Copy link
Contributor

fedeci commented Apr 3, 2022

Other completions are auto-generated... can we do the same for fig?

Also, fig will read from this repo? If so, what happens with different versions of goreleaser, which might have different flags/docs/etc?

@caarlos0
Actually we are working on a set of tools to integrate CLI repos directly with autocomplete. This will support (quite soon):

  • automatic generation of specs
  • automatic versioning
  • automatic pr creation to this repo
    Once we are done with the stuff mentioned above I can submit a PR to your CLI repo to get the integration working!

@dirien that kind of versioning is becoming outdated very soon because we are creating a new one and we still need to document it!

@fedeci fedeci changed the title feat: Add GoReleaser Spec feat: add goreleaser spec Apr 3, 2022
@fedeci fedeci merged commit 26eea1a into withfig:master Apr 3, 2022
@dirien dirien deleted the goreleaser branch April 3, 2022 11:07
@dirien
Copy link
Contributor Author

dirien commented Apr 3, 2022

Wow @fedeci, looking forward for this! As talked on discord @caarlos0, I will keep an eye on the spec for now. When something will change in the commands / flags I will update the spec.

@fedeci
Copy link
Contributor

fedeci commented Apr 3, 2022

Thanks @dirien!

teziovsky added a commit to teziovsky/fig-autocomplete that referenced this pull request Apr 3, 2022
@teziovsky @mschrage
@grant0417 @gh-action-bump-version @neoncitylights @dirien @knid
Teziovsky/lp (#3)
a56ba9d 
* feat(fig/fig@latest): update spec (withfig#1089)

* feat: update spec

* fix(fig): run linter

Co-authored-by: Grant G <grant0417@users.noreply.github.com>
Co-authored-by: grant0417 <grant@ggurvis.com>

* ci: version bump to 2.174.0

* feat: add webpack spec (withfig#1100)

* ci: version bump to 2.175.0

* feat: add goreleaser spec (withfig#1096)

* ci: version bump to 2.176.0

* feat: add tfsec spec (withfig#1099)

* ci: version bump to 2.177.0

* feat: add trivy spec (withfig#1102)

* ci: version bump to 2.178.0

* feat: add httpy completion spec (withfig#1093)

* ci: version bump to 2.179.0

Co-authored-by: Matt Schrage <matthewschrage@gmail.com>
Co-authored-by: Grant G <grant0417@users.noreply.github.com>
Co-authored-by: grant0417 <grant@ggurvis.com>
Co-authored-by: Automated Version Bump <gh-action-bump-version@users.noreply.github.com>
Co-authored-by: Samantha <sam.t.nguyenn@gmail.com>
Co-authored-by: Engin Diri <engin.diri@ediri.de>
Co-authored-by: Engin Diri <engin.diri@mail.schwarz>
Co-authored-by: Sinan Kanidağlı <82559809+SinanKanidagli@users.noreply.github.com>
@dirien dirien mentioned this pull request Aug 20, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedeci fedeci fedeci approved these changes

@QuiiBz QuiiBz Awaiting requested review from QuiiBz

@mschrage mschrage Awaiting requested review from mschrage mschrage is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[goreleaser] Missing spec
4 participants
@dirien @withfig-bot @caarlos0 @fedeci