This repository has been archived by the owner on Oct 11, 2022. It is now read-only.
Fix broken authentication #3392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ServiceWorker would automatically return our app shell for all navigation requests, including to `/auth/xyz`—which meant that users were served the app instead of getting redirected to their auth provider of choice. This fixes it by disabling the built-in `appShell` option, copying exactly what it does but filtering out the `/auth` route. (and the `/api` route for good measure)
Generated by 🚫 dangerJS |
|
This was tested locally on the production setup and works beautifully. Will get a deploy on alpha too. |
|
Found a small bug, fixed in 1693267. This is live on alpha and works perfectly! Everything is served from the ServiceWorker, and authentication works perfectly fine 👌 |
| caches: process.env.NODE_ENV === 'development' ? {} : 'all', | ||
| externals, | ||
| autoUpdate: true, | ||
| // NOTE(@mxstbr): Normally this is handled by setting |
There was a problem hiding this comment.
helpful, describable comments. nice work😀
brianlovin
approved these changes
Jun 26, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)
The ServiceWorker would automatically return our app shell for all navigation requests, including to
/auth/xyz—which meant that users were served the app instead of getting redirected to their auth provider of choice.This fixes it by disabling the built-in
appShelloption and then copying exactly what it does BUT filtering out the/authroute first. (and the/apiroute for good measure)