Skip to content
This repository has been archived by the owner on Oct 11, 2022. It is now read-only.

Shorter time to timestamp while grouping messages #4483

Merged
merged 2 commits into from
Dec 16, 2018

Conversation

brianlovin
Copy link
Contributor

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • hyperion (frontend)

@brianlovin
Copy link
Contributor Author

Context here: 6 hours is a long time before adding a timestamp. And even though we add timestamps on-hover, it can make conversations where there are multiple-hour gaps between messages confusing to read, especially in situations where someone might be answering questions or fixing a bug but there's no timestamp to indicate that time has elapsed. One hour is still kind of long but since Spectrum tends towards more async conversations we don't want to get too short here, otherwise every other message will have a timestamp divider.

@brianlovin brianlovin merged commit fe09086 into alpha Dec 16, 2018
@brianlovin brianlovin deleted the shorter-time-to-timestamp branch December 16, 2018 18:10
@mxstbr
Copy link
Contributor

mxstbr commented Dec 16, 2018

Agree with the thinking, let's see what this feels like!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants