Skip to content
This repository has been archived by the owner on Oct 11, 2022. It is now read-only.

Use clientside routing for spectrum urls #4978

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Conversation

brianlovin
Copy link
Contributor

Status

  • WIP
  • Ready for review
  • Needs testing

Deploy after merge (delete what needn't be deployed)

  • api
  • hyperion (frontend)

Related issues (delete if you don't know of any)
Closes #4912

@mxstbr will definitely need your eye on this, but in my initial testing this is a really nice quality of life improvement. On-site links don't open in new tabs and use the <Link> component for fast clientside routing.

Copy link
Contributor

@mxstbr mxstbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice little QoL improvement you got there!

@mxstbr mxstbr merged commit 60d74cc into alpha Mar 28, 2019
@mxstbr mxstbr deleted the spectrum-urls-detection branch March 28, 2019 07:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants