Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] introduces ApiRequest and dynamic dispatch across implementations #19

Merged
merged 12 commits into from
Jan 4, 2024
Merged

[REFACTOR] introduces ApiRequest and dynamic dispatch across implementations #19

merged 12 commits into from
Jan 4, 2024

Commits on Jan 4, 2024

  1. introduces pokedex.api.request package

    @withtwoemms
    withtwoemms committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    8e17bfb View commit details
    Browse the repository at this point in the history

  2. introduces pokedex.api.request.implementations package

    @withtwoemms
    withtwoemms committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    65e09a4 View commit details
    Browse the repository at this point in the history

  3. duplicates DeferredRequest protocol

    @withtwoemms
    withtwoemms committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    b755f74 View commit details
    Browse the repository at this point in the history

  4. renames enum

    @withtwoemms
    withtwoemms committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    71bc806 View commit details
    Browse the repository at this point in the history

  5. makes use of centrally-located DeferredRequest protocol

    @withtwoemms
    withtwoemms committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    20af921 View commit details
    Browse the repository at this point in the history

  6. moves BASE_URL to centrally-located pokedex.constants module

    @withtwoemms
    withtwoemms committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    7fdf4f9 View commit details
    Browse the repository at this point in the history

  7. DeferredRequest made @runtime_checkable

    @withtwoemms
    withtwoemms committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ef27243 View commit details
    Browse the repository at this point in the history

  8. moves type aliases to pokedex.api.models module

    @withtwoemms
    withtwoemms committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    ff3a2d8 View commit details
    Browse the repository at this point in the history

  9. relaxes test coverage criterion

    @withtwoemms
    withtwoemms committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    0e93eb1 View commit details
    Browse the repository at this point in the history

  10. linting

    @withtwoemms
    withtwoemms committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    4e2c6ab View commit details
    Browse the repository at this point in the history

  11. adds Report test

    @withtwoemms
    withtwoemms committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    e3c81d5 View commit details
    Browse the repository at this point in the history

  12. corrects returntype for ApiRequest.type

    @withtwoemms
    withtwoemms committed Jan 4, 2024
    Configuration menu
    Copy the full SHA
    84e4ce5 View commit details
    Browse the repository at this point in the history