Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Android and iOS folders. #211

Closed
wants to merge 4 commits into from

Conversation

DylanVann
Copy link

@DylanVann DylanVann commented May 4, 2018

This is a breaking change.

I think this should be done to:

  • Use a more standard React Native package directory structure.
  • Reduce complexity (no postinstall).
  • Reduce the probability of issues related to automatic linking and symlinking.

See: #12 (comment)

There are also several other open issues related to symlinks.

@@ -14,7 +14,7 @@ Pod::Spec.new do |s|
s.platform = :ios, "7.0"

s.source = { :git => "https://github.com/wix/react-native-interactable.git" }
s.source_files = "lib/ios/Interactable/*.{h,m}"
s.source_files = "ios/Interactable/*.{h,m}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As someone unfamiliar with .podspec I had to check at https://guides.cocoapods.org/syntax/podspec.html to assure myself that these curly braces weren't a problem here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, other project actually tend to use ios/**/*.{h,m}.

@jsispal
Copy link

jsispal commented Jun 12, 2018

Thanks @DylanVann - this fixes the build issues (local and automated). Would be great to get this PR merged in 👍

@f0rr0
Copy link

f0rr0 commented Jul 3, 2018

can this be merged? @markhu @rjpizarro

@DylanVann
Copy link
Author

I suppose someone has to step up and ask to be a maintainer. I would be willing to say I'd merge a couple things, publish the package, and not break anything, but I couldn't commit to being highly available to work on this, especially considering I think react-native-reanimated will potentially supercede this package.

@evanjmg
Copy link

evanjmg commented Jul 15, 2018

Please merge this to fix symlinks

@mnlbox
Copy link

mnlbox commented Aug 28, 2018

Please merge this as soon as possible. I'm using wix-ui-lib and can't assembleRelease because of this error:

FAILURE: Build failed with an exception.

* What went wrong:
Failed to capture snapshot of input files for task ':app:bundleReleaseJsAndAssets' property '$1' during up-to-date check.
> Could not list contents of '/home/myusername/myprojects/node_modules/react-native-interactable/{ios,android}'. Couldn't follow symbolic link.

@traxx10
Copy link

traxx10 commented Sep 3, 2018

Am also getting the same issue

@xkrsz
Copy link

xkrsz commented Sep 12, 2018

We're also experiencing this issue:

Could not list contents of '...react-native-interactable...'. Couldn't follow symbolic link.

Copy link

@HarishJangra HarishJangra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build Succesful with these changes

@rotemmiz
Copy link
Contributor

rotemmiz commented Nov 4, 2018

I am closing the PR as a part of an effort to cleanup and revive the project. If this issue persists after v1.0.0, you are more than welcome to reintroduce the PR.

Thanks for your contribution.

@rotemmiz rotemmiz closed this Nov 4, 2018
@DylanVann
Copy link
Author

I don't think closing PRs that fix persistent issues and make setup easier for people is a good way to go about "reviving the project".

I won't be reintroducing the PR.

@rotemmiz
Copy link
Contributor

No need to reintroduce the PR, this is already solved in v1.0.0-alpha.1
https://www.npmjs.com/package/react-native-interactable/v/1.0.0-alpha.1

V1 is coming soon

@DylanVann
Copy link
Author

DylanVann commented Jan 27, 2019

Yeah I saw that, although you didn't mention it here. I understand closing PRs if you have merged another superior fix, but just closing PRs to "cleanup the project" strikes me as inconsiderate.

You may want to check that react-native link works well with whatever fix you implemented.

@rotemmiz
Copy link
Contributor

rotemmiz commented Jan 27, 2019

The project was not maintained for more than a year, simply because we couldn't find time for it, and no maintainer jumped on the opportunity. The repo was even left out of Wix's apps, and we wanted it back in.
There were close to a hundred open issues and PRs and we simply couldn't handle all of those individualy.

We want to create quality open source projects, and community around it as well, I hope you didn't take this personally as it surely wasn't our intention to dismiss the work done by you or anyone else from the community.

Regarding your comment re link, we will, thanks!

@DylanVann
Copy link
Author

Trust me I can understand wanting to close all open issues and PRs on a project. I would resist the urge though, because people put time and effort into reporting issues and trying to make contributions.

I'm definitely guilty of ignoring PRs and issues, but I'd favor that over closing them without giving a reason. Anyways, no hard feelings, open source is hard 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.