-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
android build.gradle's wildcard dependencies means builds not reproducible / fail #1380
Comments
https://github.com/square/okhttp/releases/tag/parent-4.0.0-ALPHA01 was published here on May 12, 2019 (the day before we first noticed this problem): https://bintray.com/bintray/jcenter/com.squareup.okhttp3%3Aokhttp/4.0.0-alpha01 A few days after: https://github.com/square/okhttp/releases/tag/parent-4.0.0-ALPHA01 |
Can specific versions be used in place of the wildcards? I suspect not since detox allows kotlin version to be overriden: https://github.com/wix/Detox/blob/master/docs/Guide.Migration.md#migrating-from-detox-9xx-to-10xx ...and the above build failure shows that both okhttp and okio have dependencies on specific kotlin versions. When compiling a library into a react-native app, the android gradle builds expects the app and all libraries to use the same version of every library. The best way to solve that is this pattern: react-native-maps/react-native-maps@a59ebf7#diff-ac45350dc94234f6d3c8b856aacbc395 It looks to me like detox should use the same pattern for all these wildcards.
|
The use of wildcards was added in 97ec822. |
@jgreen210 I'm having this exact problem only for release build. Did you resolve this problem anyway? |
We increased the kotlin version to something that's compatible with the newly released okhttp version. That doesn't stop the same thing happening again, which would require something like the above PR. Not having our own npm registry, and since detox uses lerna, I'm not sure if/how I could test the PR though, so haven't tried it myself yet. |
Hey @jgreen210! In Detox |
Hi @d4vidi, Applying those changes to use the aar, I was able to go back to using That means that #1388 isn't required. The reactNativeVersion part could be useful in its own right though... |
Glad to hear, and sorry for the trouble. |
@jgreen210 (and whoever sees this) - I've just released |
https://github.com/wix/Detox/blob/159bdbdb073afdd872780e7885204a0484bd2d78/detox/android/detox/build.gradle has the following wildcard dependencies:
This means that builds aren't reproducible.
E.g. our android detox test app builds started failing this morning (without us making a commit) with this error:
This is with:
To Reproduce
Probably happens for every android detox test app using kotlinVersion 1.3.0.
Expected behavior
Screenshots
N/A
Environment (please complete the following information):
Device and Verbose Detox Logs
N/A
The text was updated successfully, but these errors were encountered: