Cancel explicit deps in okio and okhttp #1397
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #1380 and similar problems in some projects that compile Detox, typically running RN-59, maybe 58.
This explains the fix in a nutshell:
+
wildcard for auto version resolution - which in facts yields the newest available version, works for react native as a dep, because RN gets resolved strictly from the syntheticnode_modules/react-native/android
"repo". The "newest" version is simply the one that's installed there.okhttp
andokio
, which are found at thegoogle
and/orjcenter
repos. In the current setting, that basically gives Detox the mandate to claim it relies on new, perhaps incompatible versions (e.g.okhttp
4), while really it can work with anything not too old.Luckily,
okhttp
andokio
eventually directly and indirectly come from the dep in react native itself (e.g. via fresco), so explicitly declaring them has been rendered useless now. Example from the Detox test app: