Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some allegedly missing kotlin minification rules #2852

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

d4vidi
Copy link
Collaborator

@d4vidi d4vidi commented Jun 21, 2021

Description

In this pull request, I have (blindly*) added pro-guard rules which will force-keep some Kotlin stdlib classes, corresponding to reports of missing class - as in #2837 and #1994.

* Unfortunately, I haven't managed to to have similar crash issues reproduced on our example project. Nevertheless, I've analyzed the APK's alongside R8's output files (seeds.txt, in particular), and have managed to prove that indeed with the new rules in place, the missing kotlin classes do get bundled into the test apk.

@d4vidi d4vidi self-assigned this Jun 21, 2021
@d4vidi d4vidi merged commit cc56101 into master Jun 21, 2021
@d4vidi d4vidi deleted the kotlin-proguard-rules branch June 21, 2021 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant