Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): multi-app build and start scripts #4508

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

noomorph
Copy link
Collaborator

@noomorph noomorph commented Jun 17, 2024

Description

In this pull request, I have extended Detox config resolution so that it can take build and start scripts not only from every app, but it can take configuration-scoped overrides, where a single command does all the building or app server running.

For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

@noomorph noomorph requested a review from asafkorem June 17, 2024 11:28
@noomorph noomorph requested a review from d4vidi as a code owner June 17, 2024 11:28
@asafkorem
Copy link
Contributor

asafkorem commented Jun 17, 2024

@noomorph, can't we do that by default? by using build caching (Gradle) or something?

@noomorph
Copy link
Collaborator Author

@asafkorem the example in our E2E is merely a self-test.

The real use case is complex build scripts like the one we use for building multiple Wix apps in parallel, where Gradle cache is simply not applicable.

However, I might think on some other solution... maybe around resolveConfig.

@noomorph noomorph marked this pull request as draft June 26, 2024 14:29
@noomorph noomorph force-pushed the feat/detox-build-dedupe branch 2 times, most recently from c757f6a to c036f97 Compare July 8, 2024 15:47
@noomorph noomorph changed the title feat: detox build --dedupe feat(config): multi-app build and start scripts Jul 8, 2024
@noomorph noomorph force-pushed the feat/detox-build-dedupe branch 2 times, most recently from 2272499 to 0095b57 Compare July 8, 2024 16:21
@noomorph noomorph marked this pull request as ready for review July 8, 2024 16:27
@noomorph noomorph self-assigned this Jul 8, 2024
Copy link
Contributor

@asafkorem asafkorem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. I think it would be better to align with one term, such as "build command," "start command," "commandsConfig," etc. (EDIT: the term "script" might fit better here, more commonly used)
Anyhow, it's a green from me 🟢

detox/src/configuration/composeScriptsConfig.js Outdated Show resolved Hide resolved
@noomorph noomorph merged commit 2da5168 into master Jul 11, 2024
7 checks passed
@noomorph noomorph deleted the feat/detox-build-dedupe branch July 11, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants