Fix issue with Card's backgroundColor not working #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendyEdri
reviewed
Apr 28, 2021
src/components/card/index.tsx
Outdated
| get blurBgStyle() { | ||
| const {enableBlur} = this.props; | ||
| get backgroundStyle() { | ||
| const {enableBlur, backgroundColor = Colors.white} = this.props; | ||
|
|
||
| if (Constants.isIOS && enableBlur) { | ||
| return {backgroundColor: Colors.rgba(Colors.white, 0.85)}; |
There was a problem hiding this comment.
when the blur is enabled, aren't we supposed to pass the backgroundColor to rgba function as well?
return {backgroundColor: Colors.rgba(backgroundColor, 0.85)};
There was a problem hiding this comment.
Completely right! Fixed ✅
mendyEdri
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue with Card's backgroundColor prop not working
Changelog
Fix issue with Card's backgroundColor prop not working