Support passing a static validation message #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
added
Important for Next Release
mendyEdri
requested changes
Aug 24, 2021
| @@ -14,9 +15,10 @@ export interface ValidationMessageProps { | |||
| */ | |||
| validationMessageStyle?: TextStyle; | |||
| retainSpace?: boolean; | |||
| validate: FieldStateProps['validateOnChange']; | |||
There was a problem hiding this comment.
Suggested change
| validate: FieldStateProps['validateOnChange']; | |
| validate?: FieldStateProps['validateOnChange']; |
There was a problem hiding this comment.
Somehow this FieldStateProps['validateOnChange'] is a boolean value, and it creates typing errors in the demo-screen on validate prop, that getting there an array of strings
mendyEdri
approved these changes
Aug 24, 2021
ethanshar
added a commit
that referenced
this pull request
Sep 9, 2021
* Support passing a static validation message regardless to the validate prop * Fix typing * Fix validate typing
mendyEdri
pushed a commit
that referenced
this pull request
Oct 4, 2021
* Support passing a static validation message (#1486) * Support passing a static validation message regardless to the validate prop * Fix typing * Fix validate typing * Add leading accessory to example * Update TextField formatter signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support rendering a validation message in Incubator.TextField component regardless to validate prop
If the user just passed
validationMessagewithoutvalidateprop, we just the render the message with no conditionFix #1485
Changelog
Support passing a validation message to Incubator.TextField component regardless to validate prop