Reuse timeline for activity log #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbal-Tish
reviewed
Dec 12, 2023
Inbal-Tish
reviewed
Dec 12, 2023
Inbal-Tish
reviewed
Dec 12, 2023
Inbal-Tish
reviewed
Dec 12, 2023
Inbal-Tish
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UX leans on reusing timeline component for activity log, so adding minimal required adjustments. Ideally, icon size would be equal to text line height and width of a line is one. This can be achieved with this PR.
Changelog
Adding width prop to Line component & iconProps to Point component. This makes some of the previously static values dynamic
Additional info
Required for activity log integration