Slider 'enableShadow' prop and ColorPicker - minor UI changes #2934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Feb 5, 2024
Comment on lines
+93
to
+95
| borderBottomWidth: 0.5, | ||
| borderBottomColor: Colors.$outlineDisabled, | ||
| borderTopWidth: 0.5, |
There was a problem hiding this comment.
Consider using StyleSheet.hairlineWidth for the thin border..
| const [color, setColor] = useState(Colors.getHSL(propsColors)); | ||
|
|
||
| @@ -94,25 +94,31 @@ const GradientSlider = (props: Props) => { | |||
| return color || sliderContext.value; | |||
| }, [color, sliderContext.value]); | |||
|
|
|||
| const renderDefaultGradient = useCallback(() => { | |||
| const getHueColor = useCallback(() => { | |||
There was a problem hiding this comment.
It feels like this should be a memoize value more than a callback.. WDYT?
ethanshar
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Slider - add 'enableShadow' prop
GradientSlider - display color only changes on hue change
ColorPicker - minor UI changes
Slider - bug fix - invoke onChange only when user move slider
Changelog
Slider - add 'enableShadow' prop
GradientSlider - display color only changes on hue change
ColorPicker - minor UI changes
Slider - bug fix - invoke onChange only when user move slider
Additional info
MADS-3847