Image support in string as source, for svg strings #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitShwarts
reviewed
Mar 17, 2024
|
@adids1221 I can't check out this specific branch... Also, why is that a hotfix? |
Inbal-Tish
reviewed
Mar 17, 2024
|
@adids1221 Worth adding tests at least to the ImageUtils |
Inbal-Tish
reviewed
Mar 17, 2024
src/utils/imageUtils.ts
Outdated
| function isSvgData(source?: ImageProps['source']) { | ||
| const sourceString = (source as string); | ||
| function isSvgData(source?: ImageSourceType) { | ||
| const sourceString = source as string; |
There was a problem hiding this comment.
Why cast to a string instead of conditioning it? I think it will be clearer
Inbal-Tish
reviewed
Mar 18, 2024
src/components/image/index.tsx
Outdated
| @@ -122,7 +126,7 @@ class Image extends PureComponent<Props, State> { | |||
| public static overlayTypes = Overlay.overlayTypes; | |||
| public static overlayIntensityType = Overlay.intensityTypes; | |||
|
|
|||
| sourceTransformer?: (props: any) => ImagePropTypes.source; | |||
| sourceTransformer?: (props: any) => ImagePropTypes; | |||
There was a problem hiding this comment.
Did you mean ImageSourceType?
Inbal-Tish
approved these changes
Mar 18, 2024
Closed
adids1221
added a commit
that referenced
this pull request
Mar 18, 2024
* Image support in string as source, for svg strings * code review refactor, image utils testing * removed ImagePropTypes from Image index file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Image support strings as type for
source.Source now support
svgimage string, requested from theCTOand theweb editorteams.Changelog
Image support strings as type for
source.Additional info